Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added example to debug if all params arrive #1038

Closed
wants to merge 2 commits into from

Conversation

julianoes
Copy link
Collaborator

This was just used for debugging. It's probably not worth merging.

Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually wondering if we would not want to expose that from the param plugin? QGC does this batch request (mavlink_msg_param_request_list_pack), doesn't it? I guess it may make sense to offer it.

@julianoes
Copy link
Collaborator Author

@JonasVautherin yes we should add it internally at some point, or in the param plugin.

@julianoes julianoes closed this Apr 16, 2020
@julianoes julianoes deleted the pr-all-params-checker branch April 16, 2020 09:18
@JonasVautherin
Copy link
Collaborator

I think in the param plugin. Whether we do some caching or not is an implementation detail, but in terms of API I believe this belongs to param. Or do you think it is needed internally? Or is it the case that other plugins would need to access the param plugin? We don't have any plugin depending on another plugin yet, but I don't see why that would be an issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants