Sync with latest internal development #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The astyle download is not available anymore, however, it's enough to check the style inside docker.
This is needed, because the c++11 equivalent is not working on Android.
This did not compile in Arch Linux otherwise.
This allows additional modules to link in additional libraries if needed.
The device should only depend on the sysid. This means that multiple components are all in the same device. This fixes the case where a component such as a camera or gimbal would connect first and then prevent the communication to the autopilot because the target component ID would be wrong.
Somehow this segfaults in the Android wrapper.
This was fixed in the caller of these functions. The problem was that only a const reference of the callback was given, however this seems to be invalid later, so a copy by value is needed.
Let's simplify the mavlink command handling for now by just sending one command at a time.
Since _last_heartbeat_received_time can be modified from different threads, a mutex has been added. In addition, it was necessary to make the variable static. Otherwise strange behaviour occured: The function elapsed_since_s returned values ober 30000 seconds, although we had a heartbeat a couple of milliseconds before.
Instead of deleting the null device and creating a new device after a mavlink message has been received, we keep the null device and change it's system id. This is useful when the SDK gets instantiated before having a connection to the vehicle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings a few advancements from the past months that were missing from this repository.