Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate from protos #1779

Closed
wants to merge 1 commit into from
Closed

Generate from protos #1779

wants to merge 1 commit into from

Conversation

JonasVautherin
Copy link
Collaborator

@JonasVautherin JonasVautherin commented May 19, 2022

For some reason, when generating the code from main, I get this diff.

@julianoes am I missing something, or should that be merged? I am a bit surprised that the CI did not catch it 🤔

@JonasVautherin JonasVautherin requested a review from julianoes May 19, 2022 14:44
@JonasVautherin
Copy link
Collaborator Author

JonasVautherin commented May 19, 2022

Oh, @julianoes did you change protoc-gen-mavsdk and did not release it on PyPi?

Like we should create 1.0.3 here, right? https://github.com/mavlink/mavsdk-proto

@JonasVautherin
Copy link
Collaborator Author

@julianoes
Copy link
Collaborator

Sorry, but the dependency with that is a little tricky, isn't it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants