Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ArduPilot PreArm handling to generic #6436

Closed
wants to merge 45 commits into from
Closed

Move ArduPilot PreArm handling to generic #6436

wants to merge 45 commits into from

Conversation

DonLakeFlyer
Copy link
Contributor

  • PreArm duplicated messages are filtered such that they are spoken only if more than 10 seconds from last time spoken.
  • PreArm messages do not pop up a QGC message box
  • PreArm messages still show up in message dropdown
  • PreArm messages show up in the center of the flight map. If no PreArm message shows up again for 10 second it will be removed from the flight map.

@dagar Can you test this with PX4?

DonLakeFlyer and others added 30 commits May 7, 2018 11:51
@DonLakeFlyer
Expose sensor status to Qml
58afdad
@DonLakeFlyer
Added sensorsUnhealthyBits
9972ac7
@DonLakeFlyer
Move ArduPilot PreArm handling to generic
a1d41e5
@DonLakeFlyer
Merge pull request mavlink#6431 from DonLakeFlyer/SensorBits
6e2c810 
Vehicle. Expose sensor status to Qml
@DonLakeFlyer
Fix altitude change signalling
b20e14f
@DonLakeFlyer
Implement GeoFence persistence
e48aad6
@DonLakeFlyer
Merge pull request mavlink#6441 from DonLakeFlyer/FactValueSlider
95be320 
Fix altitude change signalling
@philipoe
Automated preflight checklist: Initial commit. Note that this require…
4466d28 
…s an autopilot firmware that writes the respective health flags in the SYS_STATUS mavlink message
@DonLakeFlyer
Switch to version 2
63abdfd 
Ignore old version 1
@DonLakeFlyer
Merge pull request mavlink#6442 from DonLakeFlyer/GeoFenceSave
ec5bffe 
Implement GeoFence persistence
@philipoe
Fixes and cleanup according to comments by @dongagne
1335850
@dagar
Update mavlink v2.0 submodule Thu May 10 20:39:36 EDT 2018
6e838e2
@dagar
Update PX4 Firmware metadata Fri May 11 00:37:05 EDT 2018
6258240
@philipoe
Fixes round 2 based on comments by @dongagne
193e1a4
@DonLakeFlyer
Merge pull request mavlink#6364 from philipoe/checklist_draft
d283233 
Automated preflight checklists
minor typo fix
07003a1
@acfloria
Add the LinkIndicator to the toolbar
77df3be 
The LinkIndicator shows the connected links and lets the user select the priority link,
@acfloria
Add AdvancedLinkSettings fact to the general app settings
7ea3296 
This setting enables/disables the LinkIndicator toolbar in which the primary link can be chosen.
@acfloria
Update active property for each link separately
321fae7 
Each link updates the active property based on incoming bytes.
The vehicle tracks the active property of each link and in case of an inactive priority link it updates the priority link.
@acfloria
Improve notification on link switching
01492d9
@acfloria
Save and load high latency property to/from link configurations
ee61860
@acfloria
Use name instead of portName in getName of the SerialLink
f4b0372
@acfloria
Fix QTimer issue and send command on high latency link change
dd28d2a
@acfloria
Use again the heartbeat instead of bytes received to determine if a l…
1e77e29 
…ink is active
@acfloria
Allow tracking multiple heartbeats for a single link
66fcbc2 
Add the HeartbeatTimer class to track a single heartbeat for a single link.
For every new received heartbeat an instance of the class is created.
Every instance emits a signal if it timed out or the timer is restarted.
Each vehicle then decides based on all different signals which link is the
priority link.
@acfloria
Fix uninitialized variable in AppSettings causing a Segfault
a7310e4
@acfloria
Do not change the priority link if it was commanded and is still active
a09fcba
@acfloria
Multi link support clean up
7c89c4a 
- Improve function names
- For notifications of an active link change only show the priority keyword if multiple links are connected
- Use QMap instead of QList for the HeartbeatTimers
- Style improvements
- Simplify sending the MAV_CMD_CONTROL_HIGH_LATENCY command
@acfloria
Remove the advanced link settings
317fe90 
Show the link indicator in the tool bar if two or more links are connected and at least one of them is a high latency link.
Show in the link indicator if a link is inactive.
@DonLakeFlyer
Fix crash when empty
a65de46
@DonLakeFlyer
Copy link
Contributor Author

@dagar Can you test?

@dagar
Copy link
Member

dagar commented May 18, 2018

Great! I'll give it a try.

Could we also do this for anything that contains "PREFLIGHT"? https://github.com/PX4/Firmware/blob/master/src/modules/commander/PreflightCheck.cpp#L131

On the PX4 side I'd still like to change them eventually, but that would get us through the transition.

@dagar dagar self-requested a review May 18, 2018 18:33
@dagar
Copy link
Member

dagar commented May 18, 2018

Which MAV_SEVERITY do you think these should be?

@dagar
Copy link
Member

dagar commented May 18, 2018

I'm thinking about treating it differently if the check is done periodically vs as a result of the user requesting to arm.

@DonLakeFlyer
Copy link
Contributor Author

Rebase went bonkers.

@DonLakeFlyer DonLakeFlyer mentioned this pull request May 19, 2018
Closed
@DonLakeFlyer DonLakeFlyer deleted the PreArm branch May 19, 2018 18:04
@dagar dagar mentioned this pull request Sep 27, 2018
Merged
This was referenced Sep 27, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagar dagar Awaiting requested review from dagar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DonLakeFlyer @dagar @philipoe @acfloria