-
Notifications
You must be signed in to change notification settings - Fork 2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix descriptions and Safari versions for canvas Path2D overloads (#9433)
The type was incorrectly described as Path. Rather than changing the IDs, just lowercase them, as this is much more typical in BCD, and the name of the argument is also path, although this is not observable. Safari version archeology: 5 of these were around when isPointInPath/isPointInStroke were added and were most likely shipped together with Path2D: https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl?rev=165927 See however #9423 about the challenge of distinguishing Safari 6.1 and 7. 7 is used because that's the version used for Path2D itself. drawFocusIfNeeded is different, it was added at WebKit trunk 538.35.0: https://trac.webkit.org/changeset/168476/webkit https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/Configurations/Version.xcconfig?rev=168476 The Path2D overload was added at WebKit trunk 601.1.1: https://trac.webkit.org/changeset/173652/webkit https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/Configurations/Version.xcconfig?rev=173652 Both are after Safari 7 was released, so that can't be right. The likely versions are instead inferred from the WebKit trunk version.
- Loading branch information
Showing
1 changed file
with
22 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters