Fix descriptions and Safari versions for canvas Path2D overloads #9433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type was incorrectly described as Path. Rather than changing the IDs, just lowercase them, as this is much more typical in BCD, and the name of the argument is also path, although this is not observable. Safari version archeology: 5 of these were around when isPointInPath/isPointInStroke were added and were most likely shipped together with Path2D: https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl?rev=165927 See however mdn#9423 about the challenge of distinguishing Safari 6.1 and 7. 7 is used because that's the version used for Path2D itself. drawFocusIfNeeded is different, it was added at WebKit trunk 538.35.0: https://trac.webkit.org/changeset/168476/webkit https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/Configurations/Version.xcconfig?rev=168476 The Path2D overload was added at WebKit trunk 601.1.1: https://trac.webkit.org/changeset/173652/webkit https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/Configurations/Version.xcconfig?rev=173652 Both are after Safari 7 was released, so that can't be right. The likely versions are instead inferred from the WebKit trunk version.
github-actions
bot
added
the
data:api
ddbeck
approved these changes
Mar 18, 2021
There was a problem hiding this comment.
Thanks, @foolip. These look like good changes to me.
See however #9423 about the challenge of distinguishing Safari 6.1 and 7. 7 is used because that's the version used for Path2D itself.
Yeah, I need to think on that one a little more. Perhaps we need to write up a semi-complicated procedure for distinguishing those versions.
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
Mar 18, 2021
ddbeck
added a commit
that referenced
this pull request
Mar 18, 2021
* Start release notes for 2021-03-18 release * Add release note for #9438 * Add release note for #9459 * Add release note for #9458 * Add release note for #9382 * Add release note for #9439 * Add release note for #9468 * Add release note for #9472 * Add release note for #9433 * Add release statistics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type was incorrectly described as Path. Rather than changing the
IDs, just lowercase them, as this is much more typical in BCD, and the
name of the argument is also path, although this is not observable.
Safari version archeology:
5 of these were around when isPointInPath/isPointInStroke were added and
were most likely shipped together with Path2D:
https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl?rev=165927
See however #9423 about
the challenge of distinguishing Safari 6.1 and 7. 7 is used because
that's the version used for Path2D itself.
drawFocusIfNeeded is different, it was added at WebKit trunk 538.35.0:
https://trac.webkit.org/changeset/168476/webkit
https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/Configurations/Version.xcconfig?rev=168476
The Path2D overload was added at WebKit trunk 601.1.1:
https://trac.webkit.org/changeset/173652/webkit
https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/Configurations/Version.xcconfig?rev=173652
Both are after Safari 7 was released, so that can't be right. The
likely versions are instead inferred from the WebKit trunk version.