Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch ES spec URLs to multipage version #10615

Merged
merged 1 commit into from
Jun 1, 2021
Merged

Switch ES spec URLs to multipage version #10615

merged 1 commit into from
Jun 1, 2021

Conversation

sideshowbarker
Copy link
Contributor

This change switches all spec URLs from the ES spec to the multipage version of the spec at https://tc39.es/ecma262/multipage/ (rather than the single-page version). The changes were generated using the script at https://gist.github.com/sideshowbarker/9941751896b23b5465a0469f41255e3c

@sideshowbarker sideshowbarker requested a review from Elchi3 May 24, 2021 11:18
@github-actions github-actions bot added the data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label May 24, 2021
@Elchi3
Copy link
Member

Elchi3 commented May 24, 2021 •
edited
Loading

Makes sense to prefer the multipage version for performance reasons.

Blocked by having this in w3c/browser-specs, though. Edit: see w3c/browser-specs#299

@sideshowbarker sideshowbarker mentioned this pull request May 24, 2021
Merged
@ddbeck ddbeck added the not ready This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. label May 24, 2021
@sideshowbarker
Switch ES spec URLs to multipage version
d77742b 
This change switches all spec URLs from the ES spec to the multipage
version of the spec at https://tc39.es/ecma262/multipage/ (rather than
the single-page version). The changes were generated using the script at
https://gist.github.com/sideshowbarker/9941751896b23b5465a0469f41255e3c
@sideshowbarker sideshowbarker force-pushed the sideshowbarker/es-spec-urls-switch-to-multipage branch from 76a6694 to d77742b Compare May 24, 2021 16:19
@tidoust tidoust mentioned this pull request May 25, 2021
Merged
@Elchi3 Elchi3 mentioned this pull request May 27, 2021
Merged
@Elchi3 Elchi3 added not ready This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. and removed not ready This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. labels May 27, 2021
@sideshowbarker
Copy link
Contributor Author

Blocked by having this in w3c/browser-specs, though. Edit: see w3c/browser-specs#299

Since that’s now been merged — and tobie/specref#661 has too — it seems like this is ready to merge?

@Elchi3
Copy link
Member

Elchi3 commented May 28, 2021

Not ready yet. See mdn/yari#3893 for how orchestrating the different packages is a bit difficult. I need to improve this before we proceed.

@sideshowbarker sideshowbarker marked this pull request as draft May 28, 2021 10:04
@sideshowbarker
Copy link
Contributor Author

Not ready yet. See mdn/yari#3893 for how orchestrating the different packages is a bit difficult. I need to improve this before we proceed.

Ah, OK — so I’ve set this to Draft status to prevent it from getting merged prematurely

@Elchi3 Elchi3 mentioned this pull request May 31, 2021
Merged
@Elchi3 Elchi3 marked this pull request as ready for review June 1, 2021 11:30
Elchi3
Elchi3 approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is now ready and we should get it on MDN in this week's release to avoid having "Unknown specification" displayed for too long.

I've opened #10681 which attempts to add a test that requires us to always update to the latest specs that w3c/browser-specs require.

@Elchi3 Elchi3 merged commit a2010d4 into mdn:main Jun 1, 2021
@sideshowbarker sideshowbarker deleted the sideshowbarker/es-spec-urls-switch-to-multipage branch June 1, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript not ready This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sideshowbarker @Elchi3 @ddbeck