build(deps): bump browser-specs from 1.38.0 to 1.38.1 #3893
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
|
@dependabot squash and merge |
|
One of your CI runs failed on this pull request, so Dependabot won't merge it. Dependabot will still automatically merge this pull request if you amend it and your tests pass. |
|
@Elchi3 CI broke. Do you think you can look into whether the test was bad or if we need to change some code? |
|
@peterbe looking into it |
|
Yeah, so some data changed in browser-specs and we have a BCD PR that changes spec_urls, too. In the tests, I was checking for exactly this data: https://github.com/mdn/yari/blob/main/testing/tests/index.test.js#L1260 If that line becomes: "https://tc39.es/ecma262/multipage/#sec-array.prototype.tolocalestring" and the BCD PR lands too then this is fine, but I wonder if it is stupid to have such a test. mdn/browser-compat-data#10615 is that BCD PR |
|
So, this is unfortunate and it will only go green if we do all of this:
Note that we usually don't mass change spec_url like done here. So, this is a one off thing but I hadn't realized it would be this complex with all the packages involved. |
|
I guess I was expecting that browser-specs keeps the single page ECMAScript version and provides the multipage version in addition, but given they replaced it, this became breaking for us. Lesson learned :) So, the alternative route to go about this one is to ask browser-specs if they could keep the original URL for backwards compat. (and generally I think I consider the single page version relevant anyways) |
|
I filed w3c/browser-specs#301 to see if browser-specs maintainers would provide both spec versions and thus would avoid a breaking data change. |
|
I struggle to keep up and fully understand what's going on here but I would definitely endorse the idea of not referring to real data in the tests. I'm not suggesting that we mock it but perhaps it's an option to simply not test the value but just check that it's anything "truthy". |
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/browser-specs-1.38.1
branch
from
01519cc to
1c114bc
Compare
|
@dependabot squash and merge |
|
Not ready to be merged yet. I'm going to work on a PR. |
|
This should pass if #3937 is merged. |
|
@dependabot rebase |
Bumps [browser-specs](https://github.com/w3c/browser-specs) from 1.38.0 to 1.38.1. - [Release notes](https://github.com/w3c/browser-specs/releases) - [Changelog](https://github.com/w3c/browser-specs/blob/master/CHANGELOG.md) - [Commits](w3c/browser-specs@1.38.0...1.38.1) Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/browser-specs-1.38.1
branch
from
1c114bc to
71bebef
Compare
|
@dependabot squash and merge |
Bumps browser-specs from 1.38.0 to 1.38.1.
Release notes
Sourced from browser-specs's releases.
Changelog
Sourced from browser-specs's changelog.
Commits
aa76bdbv1.38.1f0ddadc[data] Update spec infoa88c83bSwitch ecma262 spec to multipage version (#299)4e064c6Add CHIPS WICG proposal to monitor list (#300)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot will merge this PR once CI passes on it, as requested by @peterbe.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)