Add compat data for Node (just properties to start) #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elchi3
added
the
data:api
jpmedley
suggested changes
Feb 23, 2018
api/Node.json
Outdated
| "notes": "WebKit and old versions of Blink incorrectly do not make <code>Node</code> inherit from <code>EventTarget</code>." | ||
| }, | ||
| "chrome_android": { | ||
| "version_added": null |
There was a problem hiding this comment.
Chrome Android should match Webview Android.
| "version_added": null | ||
| }, | ||
| "chrome_android": { | ||
| "version_added": null |
There was a problem hiding this comment.
All Chrome versions should be true. You can verify support of all of Node's members in the IDL file.
api/Node.json
Outdated
| "version_added": "1" | ||
| }, | ||
| "chrome_android": { | ||
| "version_added": "1" |
There was a problem hiding this comment.
There was no version 1 for Chrome Android. Please change to true. Change Webview Android to true as well.
api/Node.json
Outdated
| "version_added": "1" | ||
| }, | ||
| "chrome_android": { | ||
| "version_added": "1" |
api/Node.json
Outdated
| }, | ||
| "chrome_android": { | ||
| "version_added": "2.3", | ||
| "notes": "probably earlier" |
There was a problem hiding this comment.
Change this to true and remove the notes. Android Chrome and Android Webview follow Chrome version numbers, not Android.
There was a problem hiding this comment.
👍 Assuming webview_android is true too.
api/Node.json
Outdated
| "version_added": true | ||
| }, | ||
| "chrome_android": { | ||
| "version_added": null |
api/Node.json
Outdated
| "version_added": true | ||
| }, | ||
| "chrome_android": { | ||
| "version_added": null |
There was a problem hiding this comment.
This is actually false for all 5.
| "version_added": null | ||
| }, | ||
| "chrome_android": { | ||
| "version_added": null |
api/Node.json
Outdated
| "chrome": { | ||
| "version_added": false, | ||
| "alternative_name": "getRootNode" | ||
| }, |
api/Node.json
Outdated
| "version_added": "1" | ||
| }, | ||
| "chrome_android": { | ||
| "version_added": "4.4" |
There was a problem hiding this comment.
Should be true for Webview, Chrome Android, and Opera.
|
Should be updated :) - will add the methods once @Elchi3 has commented. |
jpmedley
approved these changes
Feb 26, 2018
Elchi3
approved these changes
Mar 6, 2018
dontcallmedom
pushed a commit
to dontcallmedom/browser-compat-data
that referenced
this pull request
Mar 17, 2018
mlbrgl
pushed a commit
to mlbrgl/browser-compat-data
that referenced
this pull request
Mar 29, 2018
foolip
added a commit
to foolip/browser-compat-data
that referenced
this pull request
Nov 27, 2020
This is a Gecko "ChromeOnly" attribute not exposed to the web: https://github.com/mozilla/gecko-dev/blob/8a4aa0c699d9ec281d1f576c9be1c6c1f289e4e7/dom/webidl/Node.webidl#L107 The string "nodePrincipal" does not appear in Chromium or WebKit source, apart from one instane in a gecko_dom.js as part of a test suite. The "API was moved" notes for Chromium are from mdn#1179 and must be a mistake, as the string "nodePrincipal" has never appeared in a commit message in the entire history of Chromium. https://developer.mozilla.org/en-US/docs/Web/API/Node/nodePrincipal should be redirected to Node.
Elchi3
pushed a commit
that referenced
this pull request
Nov 27, 2020
This is a Gecko "ChromeOnly" attribute not exposed to the web: https://github.com/mozilla/gecko-dev/blob/8a4aa0c699d9ec281d1f576c9be1c6c1f289e4e7/dom/webidl/Node.webidl#L107 The string "nodePrincipal" does not appear in Chromium or WebKit source, apart from one instane in a gecko_dom.js as part of a test suite. The "API was moved" notes for Chromium are from #1179 and must be a mistake, as the string "nodePrincipal" has never appeared in a commit message in the entire history of Chromium. https://developer.mozilla.org/en-US/docs/Web/API/Node/nodePrincipal should be redirected to Node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.mozilla.org/en-US/docs/Web/API/Node
Note - starting off with just the properties, will add methods once this has been approved.
Also note there are a few properties with no table and so I have represented this as all nulls, can't remember if this is the correct procedure.