Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the api.Node.nodePrincipal entry #7521

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Conversation

foolip
Copy link
Contributor

@foolip foolip commented Nov 27, 2020

This is a Gecko "ChromeOnly" attribute not exposed to the web:
https://github.com/mozilla/gecko-dev/blob/8a4aa0c699d9ec281d1f576c9be1c6c1f289e4e7/dom/webidl/Node.webidl#L107

The string "nodePrincipal" does not appear in Chromium or WebKit source,
apart from one instane in a gecko_dom.js as part of a test suite.

The "API was moved" notes for Chromium are from
#1179 and must be a
mistake, as the string "nodePrincipal" has never appeared in a commit
message in the entire history of Chromium.

https://developer.mozilla.org/en-US/docs/Web/API/Node/nodePrincipal
should be redirected to Node.

This is a Gecko "ChromeOnly" attribute not exposed to the web:
https://github.com/mozilla/gecko-dev/blob/8a4aa0c699d9ec281d1f576c9be1c6c1f289e4e7/dom/webidl/Node.webidl#L107

The string "nodePrincipal" does not appear in Chromium or WebKit source,
apart from one instane in a gecko_dom.js as part of a test suite.

The "API was moved" notes for Chromium are from
mdn#1179 and must be a
mistake, as the string "nodePrincipal" has never appeared in a commit
message in the entire history of Chromium.

https://developer.mozilla.org/en-US/docs/Web/API/Node/nodePrincipal
should be redirected to Node.
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 27, 2020
@Elchi3
Copy link
Member

Elchi3 commented Nov 27, 2020

https://developer.mozilla.org/en-US/docs/Web/API/Node/nodePrincipal
should be redirected to Node.

Done and also removed mentions of nodePrincipal on https://wiki.developer.mozilla.org/en-US/docs/Web/API/Node

@Elchi3 Elchi3 merged commit 1909933 into mdn:master Nov 27, 2020
@foolip foolip deleted the nodePrincipal branch November 27, 2020 15:08
@foolip
Copy link
Contributor Author

foolip commented Nov 27, 2020

Excellent, thanks @Elchi3! As thanks you get #7520 as well, if you like :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants