Update Safari versions for DOMTokenList API #12138
Conversation
This PR updates and corrects the real values for Safari (Desktop and iOS/iPadOS) for the `DOMTokenList` API, based upon results from the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v3.2.9). Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/DOMTokenList
github-actions
bot
added
the
data:api 🐇
There was a problem hiding this comment.
This is earlier than api.Element.classList, which I believe was the first API to use DOMTokenList. Can you double check if that should also be supported earlier?
Also note that https://mdn-bcd-collector.appspot.com/tests/api/DOMTokenList is testing the interface object only, so it's possible this was supported even earlier but the interface was not exposed.
|
Based upon additional testing, it does seem like the interface was accidentally exposed in earlier Safari versions. I've updated the data to match the new tests and the |
api/DOMTokenList.json
Outdated
| @@ -30,7 +30,7 @@ | |||
| "version_added": "11.5" | |||
| }, | |||
| "safari": { | |||
| "version_added": "5.1" | |||
| "version_added": "6" | |||
| }, | |||
| "safari_ios": { | |||
| "version_added": "5" | |||
There was a problem hiding this comment.
Does this also need to be updated to 6? https://developer.mozilla.org/en-US/docs/Web/API/Element/classList#browser_compatibility has a range starting at 5, but that seems implausible, that might just be wrong too.
There was a problem hiding this comment.
It seems to be just mirroring the original desktop data. Fixing now!
This PR updates and corrects the real values for Safari (Desktop and iOS/iPadOS) for the
DOMTokenListAPI, based upon results from the mdn-bcd-collector project (v3.2.9).Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/DOMTokenList