Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Safari 6.1 #11156

Merged
merged 5 commits into from
Dec 6, 2021
Merged

Remove Safari 6.1 #11156

merged 5 commits into from
Dec 6, 2021

Conversation

queengooborg
Copy link
Collaborator

This PR removes Safari 6.1 from the data and converts all of its entries to Safari 7. Details are described in #9423, but to summarize, it seems that Safari 6.1 and 6.2 are simply backports of Safari 7.0 and 7.1 for older macOS versions, similar to Safari 4.1 and 5.0.

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 19, 2021
@foolip foolip mentioned this pull request Jun 19, 2021
@foolip
Copy link
Collaborator

foolip commented Jun 19, 2021

I looked into making this changes yesterday on a branch, which I've created as #11157 now. That has a bunch of different commits, and only "Change where iOS is 7" is trivial IMHO. I'd especially want to look into the cases where iOS said 6.1, since that has the same WebKit version as iOS 6. I don't really believe that data, but if we did we'd change iOS 6.1 to 6, not 7. So for those we need to research what it should really be.

foolip added a commit to foolip/browser-compat-data that referenced this pull request Jun 21, 2021
This subset of mdn#11156
does not need much scrutinty, as this results in the expected matching
of Safari and iOS versions. There may still be errors in this data, but
then it's wrong for both Safaris.

Part of mdn#9423.
foolip added a commit to foolip/browser-compat-data that referenced this pull request Jun 21, 2021
This subset of mdn#11156
does not need much scrutiny, as this results in the expected matching of
Safari and iOS versions. There may still be errors in this data, but
then it's wrong for both Safaris.

Part of mdn#9423.
foolip added a commit to foolip/browser-compat-data that referenced this pull request Jun 21, 2021
This subset of mdn#11156
does not need much scrutiny, as this results in the expected matching of
Safari and iOS versions. There may still be errors in this data, but
then it's wrong for both Safaris.

Part of mdn#9423.
foolip added a commit to foolip/browser-compat-data that referenced this pull request Jun 21, 2021
This subset of mdn#11156
does not need much scrutiny, as this results in the expected matching of
Safari and iOS versions. There may still be errors in this data, but
then it's wrong for both Safaris.

Part of mdn#9423.
queengooborg pushed a commit that referenced this pull request Jun 22, 2021
This subset of #11156
does not need much scrutiny, as this results in the expected matching of
Safari and iOS versions. There may still be errors in this data, but
then it's wrong for both Safaris.

Part of #9423.
@github-actions github-actions bot added data:browsers 🌍 Data about browsers (versions, release dates, etc). This data is used for validation. data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS labels Jun 22, 2021
api/Window.json Outdated
@@ -1670,10 +1670,10 @@
"version_added": "24"
},
"safari": {
"version_added": "6.1"
"version_added": "7"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using http://mdn-bcd-collector.appspot.com/tests/api/Window/crypto it looks like window.crypto was actually added in Safari 5.1. Maybe the collector can be used to update a bunch of this data?

@queengooborg queengooborg added the not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. label Jul 16, 2021
@queengooborg
Copy link
Collaborator Author

I'm marking this as "not ready" as I'm planning to talk to Daniel about what we want to do with Safari 6.1.

@queengooborg queengooborg removed the not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. label Aug 22, 2021
@queengooborg
Copy link
Collaborator Author

Removing the "not ready" flag -- we've just about come to a conclusion to remove Safari 6.1!

@foolip
Copy link
Collaborator

foolip commented Aug 23, 2021

@vinyldarkscratch was most of this produced by a script so that you can easily recreate it? If so, could you separate it into multiple commits and PRs to make it easier to review? In particular, all the cases where 6.1+6.1 are changed to 7+7 are ones I don't feel need any review at all. Splitting just that out would probably make the rest small enough to review together.

@queengooborg
Copy link
Collaborator Author

It was generated by a quick grep and sed replacement, but I could instead run the collector on these and get accurate results? I can split that into separate PRs for easier review too.

@foolip
Copy link
Collaborator

foolip commented Aug 23, 2021

A separate PR any APIs that the collector determines were supported before 6.1 would be great.

@queengooborg queengooborg added the not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. label Aug 23, 2021
@queengooborg queengooborg removed data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS labels Aug 24, 2021
@queengooborg queengooborg added not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. and removed not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. labels Oct 9, 2021
@queengooborg
Copy link
Collaborator Author

Current remaining entries are:

→ css.properties.align-self.flex_context
→ css.properties.clip-path
→ css.properties.clip-path.basic_shape
→ css.properties.clip-path.html
→ css.properties.clip-path.svg
→ css.properties.display.inline-flex
→ css.properties.flex-wrap
→ css.properties.font-feature-settings
→ css.properties.justify-content.flex_context
→ css.properties.min-height.fit-content
→ css.properties.position.sticky
→ css.properties.ruby-position
→ css.properties.width.animatable
→ css.properties.width.stretch
→ css.properties.word-spacing.percentages
→ css.selectors.cue
→ css.selectors.cue.selector_argument
→ css.selectors.future
→ css.selectors.past
→ css.types.image.gradient.linear-gradient
→ css.types.image.gradient.linear-gradient.interpolation_hints
→ css.types.image.gradient.linear-gradient.to
→ css.types.image.gradient.linear-gradient.unitless_0_angle
→ css.types.image.gradient.radial-gradient
→ css.types.image.gradient.radial-gradient.interpolation_hints
→ css.types.image.gradient.repeating-linear-gradient
→ css.types.image.gradient.repeating-linear-gradient.interpolation_hints
→ css.types.image.gradient.repeating-linear-gradient.to
→ css.types.image.gradient.repeating-linear-gradient.unitless_0_angle
→ css.types.length-percentage.vmax
→ css.types.length-percentage.vmin
→ css.types.length.vmax
→ css.types.length.vmin
→ html.elements.details
→ html.elements.details.open
→ javascript.builtins.Array.toLocaleString.locales_parameter
→ javascript.builtins.Array.toLocaleString.options_parameter
→ svg.elements.use.external_uri

@queengooborg
Copy link
Collaborator Author

The remaining features are all covered by #13867, #13868, #13869, #13870.

@foolip
Copy link
Collaborator

foolip commented Dec 6, 2021

@queengooborg those PRs are merged, this now need rebasing.

@queengooborg queengooborg added rebase needed 🚧 infra 🏗️ Infrastructure issues (npm, GitHub Actions, releases) of this project and removed not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. labels Dec 6, 2021
@queengooborg
Copy link
Collaborator Author

Oops, one more: #13888!

@foolip
Copy link
Collaborator

foolip commented Dec 6, 2021

Also merged!

@queengooborg
Copy link
Collaborator Author

Alright, this is now ready to go! Whoo!

@foolip foolip merged commit 5a1494b into mdn:main Dec 6, 2021
@queengooborg queengooborg deleted the browsers/remove-safari-6.1 branch December 6, 2021 15:29
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Dec 7, 2021
ddbeck added a commit that referenced this pull request Dec 7, 2021
* Bump version to v4.1.1

* Add initial release notes

* Add release note for #11156

* Add stats

* Fix previous release note version
jpmedley pushed a commit that referenced this pull request Jan 10, 2022
* Bump version to v4.1.1

* Add initial release notes

* Add release note for #11156

* Add stats

* Fix previous release note version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:browsers 🌍 Data about browsers (versions, release dates, etc). This data is used for validation. infra 🏗️ Infrastructure issues (npm, GitHub Actions, releases) of this project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants