Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Safari versions for Document API #12140

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Update Safari versions for Document API #12140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions api/Document.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,10 @@
"version_added": "44"
},
"safari": {
"version_added": "6.1"
"version_added": "8"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem right, http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=9577 on Safari 6.2 shows it was supported there.

Which versions of Safari are you testing on for these updates, and does it map 6.1, 6.2 and any other backport releases correctly? We never merged foolip/mdn-bcd-collector#1244 and I guess the collector just does the wrong thing by default still?

Copy link
Collaborator Author

@queengooborg queengooborg Aug 26, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually Safari 6.2 is a backport of Safari 7.1, which in turn is a backport of Safari 8! I'm testing on Safari 6.0, 7.0, and 8.0 (6.0 and 8.0 with BrowserStack, and 7.0 with a local VM).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I can't keep the mapping in my head :)

},
"safari_ios": {
"version_added": "6.1"
"version_added": "8"
},
"samsunginternet_android": {
"version_added": "8.0"
Expand Down Expand Up @@ -2953,7 +2953,7 @@
"version_added": "16"
},
"safari": {
"version_added": "6.1"
"version_added": "8"
},
"safari_ios": {
"version_added": "8"
Expand Down Expand Up @@ -8097,11 +8097,11 @@
"version_removed": "50"
},
"safari": {
"version_added": "6.1",
"version_added": "7",
"version_removed": "14"
},
"safari_ios": {
"version_added": "6.1",
"version_added": "7",
"version_removed": "14"
},
"samsunginternet_android": {
Expand Down Expand Up @@ -11618,7 +11618,7 @@
"version_added": "45"
},
"safari": {
"version_added": "6.1"
"version_added": "7"
},
"safari_ios": {
"version_added": false
Expand Down