Update Safari versions for Document API #12140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates and corrects the real values for Safari (Desktop and iOS/iPadOS) for the `Document` API, based upon results from the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v3.2.9). Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/Document
github-actions
bot
added
the
data:api 🐇
Merged
foolip
requested changes
Aug 25, 2021
| @@ -86,10 +86,10 @@ | |||
| "version_added": "44" | |||
| }, | |||
| "safari": { | |||
| "version_added": "6.1" | |||
| "version_added": "8" | |||
There was a problem hiding this comment.
This doesn't seem right, http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=9577 on Safari 6.2 shows it was supported there.
Which versions of Safari are you testing on for these updates, and does it map 6.1, 6.2 and any other backport releases correctly? We never merged foolip/mdn-bcd-collector#1244 and I guess the collector just does the wrong thing by default still?
There was a problem hiding this comment.
Actually Safari 6.2 is a backport of Safari 7.1, which in turn is a backport of Safari 8! I'm testing on Safari 6.0, 7.0, and 8.0 (6.0 and 8.0 with BrowserStack, and 7.0 with a local VM).
There was a problem hiding this comment.
OK, I can't keep the mapping in my head :)
foolip
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates and corrects the real values for Safari (Desktop and iOS/iPadOS) for the
DocumentAPI, based upon results from the mdn-bcd-collector project (v3.2.9).Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/Document