Update Safari versions for TextTrackCue API #12148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates and corrects the real values for Safari (Desktop and iOS/iPadOS) for the `TextTrackCue` API, based upon results from the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v3.2.9). Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/TextTrackCue
github-actions
bot
added
the
data:api 🐇
Merged
foolip
reviewed
Aug 23, 2021
| }, | ||
| "safari_ios": { | ||
| "version_added": "8" | ||
| "version_added": "7" |
There was a problem hiding this comment.
Is this based on mirroring? Wasn't a bunch of text track stuff enabled in iOS 8?
There was a problem hiding this comment.
This was based on testing, actually. The text track APIs were enabled in iOS 7 rather than iOS 8.
foolip
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates and corrects the real values for Safari (Desktop and iOS/iPadOS) for the
TextTrackCueAPI, based upon results from the mdn-bcd-collector project (v3.2.9).Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/TextTrackCue