-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the performance attribute to api.performance (in _globals) #12462
Conversation
This was missed in mdn#11518. This is defined using WindowOrWorkerGlobalScope in the spec: https://w3c.github.io/hr-time/#the-performance-attribute None of the data was validated or changed, just moved.
@Elchi3 could I tempt you into preparing the content-side change for this, since you already did a whole lot of these and know all the bits to update? |
I'm happy to help with the content work on this one but it runs into the same problem that I also ran into with Here, |
Oh, I didn't realize this would happen, that MDN URLs are case-insensitive... any ideas for how to resolve this? |
No yet. One could have an MDN URL like |
Could we disambiguate "Performance (interface)" and "performance (property)" Wikipedia-style? One of them should probably be very minimal and just link to the other. |
I'm not a big fan of disambiguation pages. I think the current Performance (interface) page is great and having a disambiguation in its place wouldn't be ideal, imo. Or where do you propose that such disambiguation would happen? |
I agree the page with all the Perhaps more radical would be to just have one page and not use the BCD for |
I think this is a good idea. |
Co-authored-by: Florian Scholz <fs@florianscholz.com>
@Elchi3 do you think this change would be trivial on the MDN side, or is something novel needed for the first some_property page? |
I've exercised the change in mdn/content#9279. I think it could work as proposed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content work was merged. Lets do this
* Bump version to v4.0.6 * Add release note for #12094 * Add release note for #12367 * Add release note for #12462 * Add release note for #12490 * Add release note for #12565 * Add release note for #12632 * Add release note for #12638 * Add release note for #12639 * Add release note for #12703 * Add release note for #12718 * Add release note for #12723 * Add release note for #12768 * Add release note for #12770 * Add release note for #12772 * Add release note for #12794 * Add release note for #12796 * Add release note for #12813 * Add stats and hoist known issues
This was missed in #11518.
This is defined using WindowOrWorkerGlobalScope in the spec:
https://w3c.github.io/hr-time/#the-performance-attribute
None of the data was validated or changed, just moved.