Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the performance attribute to api.performance (in _globals) #12462

Merged
merged 2 commits into from
Sep 29, 2021

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Sep 17, 2021

This was missed in #11518.

This is defined using WindowOrWorkerGlobalScope in the spec:
https://w3c.github.io/hr-time/#the-performance-attribute

None of the data was validated or changed, just moved.

This was missed in mdn#11518.

This is defined using WindowOrWorkerGlobalScope in the spec:
https://w3c.github.io/hr-time/#the-performance-attribute

None of the data was validated or changed, just moved.
@foolip foolip added needs-release-note 📰 needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation labels Sep 17, 2021
@foolip foolip requested a review from Elchi3 September 17, 2021 08:11
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Sep 17, 2021
@foolip
Copy link
Collaborator Author

foolip commented Sep 17, 2021

@Elchi3 could I tempt you into preparing the content-side change for this, since you already did a whole lot of these and know all the bits to update?

@Elchi3
Copy link
Member

Elchi3 commented Sep 17, 2021

I'm happy to help with the content work on this one but it runs into the same problem that I also ran into with crypto: The namespace is already occupied. (see #11518 (comment))

Here, performance also conflicts with the interface: https://developer.mozilla.org/en-US/docs/Web/API/Performance

@foolip
Copy link
Collaborator Author

foolip commented Sep 17, 2021

Oh, I didn't realize this would happen, that MDN URLs are case-insensitive... any ideas for how to resolve this?

@Elchi3
Copy link
Member

Elchi3 commented Sep 17, 2021

Oh, I didn't realize this would happen, that MDN URLs are case-insensitive... any ideas for how to resolve this?

No yet. One could have an MDN URL like performance_global. Other ideas?

@foolip
Copy link
Collaborator Author

foolip commented Sep 17, 2021

Could we disambiguate "Performance (interface)" and "performance (property)" Wikipedia-style? One of them should probably be very minimal and just link to the other.

@Elchi3
Copy link
Member

Elchi3 commented Sep 17, 2021

I'm not a big fan of disambiguation pages. I think the current Performance (interface) page is great and having a disambiguation in its place wouldn't be ideal, imo. Or where do you propose that such disambiguation would happen?

@foolip
Copy link
Collaborator Author

foolip commented Sep 17, 2021

I agree the page with all the Performance members is the best place to land. How about https://developer.mozilla.org/en-US/docs/Web/API/Performance stays the same but https://developer.mozilla.org/en-US/docs/Web/API/performance_property is added?

Perhaps more radical would be to just have one page and not use the BCD for api.performance at all, since it should match api.Performance.

@Elchi3
Copy link
Member

Elchi3 commented Sep 17, 2021

I agree the page with all the Performance members is the best place to land. How about https://developer.mozilla.org/en-US/docs/Web/API/Performance stays the same but https://developer.mozilla.org/en-US/docs/Web/API/performance_property is added?

I think this is a good idea.

api/_globals/performance.json Outdated Show resolved Hide resolved
Co-authored-by: Florian Scholz <fs@florianscholz.com>
@foolip
Copy link
Collaborator Author

foolip commented Sep 24, 2021

@Elchi3 do you think this change would be trivial on the MDN side, or is something novel needed for the first some_property page?

@Elchi3
Copy link
Member

Elchi3 commented Sep 27, 2021

I've exercised the change in mdn/content#9279. I think it could work as proposed.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content work was merged. Lets do this

@Elchi3 Elchi3 merged commit 688bbf4 into mdn:main Sep 29, 2021
@Elchi3 Elchi3 removed the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Sep 29, 2021
@foolip foolip deleted the api.performance branch September 29, 2021 08:24
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Oct 12, 2021
ddbeck added a commit that referenced this pull request Oct 12, 2021
* Bump version to v4.0.6

* Add release note for #12094

* Add release note for #12367

* Add release note for #12462

* Add release note for #12490

* Add release note for #12565

* Add release note for #12632

* Add release note for #12638

* Add release note for #12639

* Add release note for #12703

* Add release note for #12718

* Add release note for #12723

* Add release note for #12768

* Add release note for #12770

* Add release note for #12772

* Add release note for #12794

* Add release note for #12796

* Add release note for #12813

* Add stats and hoist known issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants