-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove irrelevant MouseWheelEvent API #12565
Remove irrelevant MouseWheelEvent API #12565
Conversation
This PR removes the irrelevant `MouseWheelEvent` API as per the corresponding [data guidelines](https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#removal-of-irrelevant-features). The lack of current support has been confirmed by the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v3.3.0), even if the current BCD suggests support.
Was this in Edge 18? If so it's still too early to remove per guideline. |
It was not in Edge 18, I did check that! |
Excellent! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not merging, please land the MDN change first.
What about the associated event https://developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers/onmousewheel ? Even though we redirect, could you clean up some of the internal links? e.g. might be simple enough just to turn them from links to code-only. |
I've opened a follow-up PR to the content repo! I'll go ahead and merge this since the main removal is complete. |
@queengooborg could you link to the corresponding content PR? It's not clear to me that the needs-content-update label was satisfied before merging. |
* Bump version to v4.0.6 * Add release note for #12094 * Add release note for #12367 * Add release note for #12462 * Add release note for #12490 * Add release note for #12565 * Add release note for #12632 * Add release note for #12638 * Add release note for #12639 * Add release note for #12703 * Add release note for #12718 * Add release note for #12723 * Add release note for #12768 * Add release note for #12770 * Add release note for #12772 * Add release note for #12794 * Add release note for #12796 * Add release note for #12813 * Add stats and hoist known issues
Certainly! The removal was done in mdn/content#9244, which had satisfied the content updates for us to be able to remove this feature. Follow-up cleanup was then done in mdn/content#9319. |
This PR removes the irrelevant
MouseWheelEvent
API as per the corresponding data guidelines. The lack of current support has been confirmed by the mdn-bcd-collector project (v3.3.0), even if the current BCD suggests support. I've also manually confirmed a lack of support by checking Chrome's and Safari's sources, and checked Edge for compatibility.