Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XHR API: Single event entries #13799

Merged
merged 5 commits into from
Feb 11, 2022
Merged

XHR API: Single event entries #13799

merged 5 commits into from
Feb 11, 2022

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Nov 29, 2021

Second attempt to merge XHR events to single entries.
See #13598 (comment) for context

Here I'm removing XMLHttpRequestEventTarget entirely and events are installed on XMLHttpRequest and XMLHttpRequestUpload. I'm assuming same compat data, but I think @foolip assumes they are different. Happy to adjust.

@Elchi3 Elchi3 added the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Nov 29, 2021
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 29, 2021
@Elchi3
Copy link
Member Author

Elchi3 commented Nov 29, 2021

I'm assuming same compat data, but I think @foolip assumes they are different. Happy to adjust.

The consistency checker already found out that I was wrong. I adjusted to the versions of the main XMLHttpRequestUpload feature.

@foolip
Copy link
Collaborator

foolip commented Nov 29, 2021

Here I'm removing XMLHttpRequestEventTarget entirely and events are installed on XMLHttpRequest and XMLHttpRequestUpload. I'm assuming same compat data, but I think @foolip assumes they are different. Happy to adjust.

Indeed, because the upload property was added later than XHR itself, so all of the XMLHttpRequestUpload data should be clamped to those version. However, I see they're currently inconsistent, which we need to sort out first I think. @queengooborg can you confirm the correct versions for api.XMLHttpRequest.upload? I assume that the Safari data in particular is wrong, this must be older than Safari 10...

@queengooborg
Copy link
Collaborator

queengooborg commented Dec 5, 2021

It looks like the upload property has been supported in Safari since Safari 4, so our data is incorrect. I've opened #13874!

@ddbeck
Copy link
Collaborator

ddbeck commented Jan 18, 2022

@Elchi3 This is blocked by merge conflicts, in case you hadn't seen so yet.

@Elchi3 Elchi3 changed the title XHR API: Single event entries / remove XMLHttpRequestEventTarget XHR API: Single event entries Feb 1, 2022
@Elchi3 Elchi3 removed the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Feb 11, 2022
@Elchi3 Elchi3 merged commit 6352c4c into mdn:main Feb 11, 2022
@Elchi3 Elchi3 deleted the xhr-events-2 branch February 11, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants