-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update XHR event pages #12896
Merged
Merged
Update XHR event pages #12896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:Learn
Learning area docs
Content:wasm
WebAssembly docs
Content:WebAPI
Web API docs
labels
Feb 10, 2022
sideshowbarker
approved these changes
Feb 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the XHR API for new-style event pages. (see the template)
Here, events aren't installed under XMLHttpRequestEventTarget anymore. (see the discussion in the BCD issue). Instead,
XMLHttpRequestEventTarget
is made a page that explains how it basically a mixin forXMLHttpRequest
andXMLHttpRequestUpload
. It is technically not a mixin, that's why the page is kept (and it is exposed to the web). The inheritance of it is the important information.Commands used to move pages around:
BCD: mdn/browser-compat-data#13799