Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add durationFormat compat table #15033

Merged
merged 9 commits into from
Jun 9, 2023
Merged

Conversation

romulocintra
Copy link
Contributor

Summary

Add Browser compact for Intl.DurationFormat API

Test results and supporting details

Test are failing for the regex "spec_url": "https://tc39.es/proposal-intl-duration-format"

Related issues

@github-actions github-actions bot added the data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Feb 18, 2022
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Usually we only add new features when there is any implementation, so this doesn't yet meet the bar.

javascript/builtins/intl/DurationFormat.json Outdated Show resolved Hide resolved
Co-authored-by: Florian Scholz <fs@florianscholz.com>
@queengooborg queengooborg added the not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. label Mar 4, 2022
@queengooborg
Copy link
Collaborator

Hey @romulocintra, thank you for your patience on this! We have decided not to include features that have no compatibility in BCD. A spec may implement a feature, but then rename or remove it before any browsers implement it, thus leaving a leftover statement in BCD.

Would you be down to research if any browsers support this feature now? If not, I'd be happy to look into it and follow up!

@romulocintra
Copy link
Contributor Author

romulocintra commented Jun 22, 2022

Hey @romulocintra, thank you for your patience on this! We have decided not to include features that have no compatibility in BCD. A spec may implement a feature, but then rename or remove it before any browsers implement it, thus leaving a leftover statement in BCD.

Would you be down to research if any browsers support this feature now? If not, I'd be happy to look into it and follow up!

Hi Thanks for having a look at it, maybe we can hold back this PR, looks like implementations will take more than expected, first due to some cross-proposal dependencies that were sorted out recently but look like we still have a couple of months ahead of landing in an engine.

MDN PR it's on hold for the same reason mdn/content#11817

@romulocintra romulocintra marked this pull request as draft June 22, 2022 19:23
@Elchi3
Copy link
Member

Elchi3 commented Mar 28, 2023

This is in Safari 16.4. We an accept this PR now.

https://webkit.org/blog/13966/webkit-features-in-safari-16-4/

romulocintra and others added 2 commits March 28, 2023 23:11
@romulocintra romulocintra marked this pull request as ready for review March 29, 2023 13:26
Copy link
Member

@Elchi3 Elchi3 Mar 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this creating a new folder intl instead of putting it in the existing folder Intl?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it is but this seems like it might've been a Git screwup. I've just pushed a fix that moves the file into the existing folder.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this misses entries for supportedLocalesOf and resolvedOptions

@queengooborg queengooborg removed the not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. label May 19, 2023
@Elchi3
Copy link
Member

Elchi3 commented May 19, 2023

I think this misses entries for supportedLocalesOf and resolvedOptions

These two are still missing,

@Elchi3 Elchi3 merged commit 5db0db8 into mdn:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants