Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference for Intl.DurationFormat #11817

Merged
merged 24 commits into from
Mar 30, 2023
Merged

Conversation

romulocintra
Copy link
Contributor

Summary

MDN Docs for https://github.com/tc39/proposal-intl-duration-format

Supporting details

Related issues

tc39/ecma402-mdn#22

Metadata

  • Adds a new document
  • Rewrites (or significantly expands) a document
  • Fixes a typo, bug, or other error

@github-actions github-actions bot added the Content:JS JavaScript docs label Jan 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2022

Preview URLs (6 pages)
Flaws (5)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DurationFormat
Title: Intl.DurationFormat
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: javascript.builtins.Intl.DurationFormat

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DurationFormat/DurationFormat
Title: Intl.DurationFormat() constructor
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: javascript.builtins.Intl.DurationFormat.DurationFormat

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DurationFormat/format
Title: Intl.DurationFormat.prototype.format()
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: javascript.builtins.Intl.DurationFormat.format

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DurationFormat/resolvedOptions
Title: Intl.DurationFormat.prototype.resolvedOptions()
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: javascript.builtins.Intl.DurationFormat.resolvedOptions

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DurationFormat/formatToParts
Title: Intl.DurationFormat.prototype.formatToParts()
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: javascript.builtins.Intl.DurationFormat.formatToParts
External URLs (1)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DurationFormat/resolvedOptions
Title: Intl.DurationFormat.prototype.resolvedOptions()

(comment last updated: 2023-03-30 07:56:39)

@romulocintra romulocintra marked this pull request as ready for review February 18, 2022 11:11
@romulocintra romulocintra requested a review from a team as a code owner February 18, 2022 11:11
@romulocintra romulocintra requested review from wbamberg and removed request for a team February 18, 2022 11:11
@romulocintra
Copy link
Contributor Author

Still missing a few things but we can start reviewing

  • Examples for formatToParts
  • Browser Compat

@romulocintra romulocintra changed the title constructor page and main slug Intl.Duration Format - MDN docs Feb 18, 2022
@teoli2003 teoli2003 self-requested a review March 11, 2022 07:57
@wbamberg
Copy link
Collaborator

@romulocintra , sorry to be so slow getting to this PR. It looks like this isn't implemented anywhere yet, so I'm not sure we are ready to have docs on MDN for it (also it's hard, for example, for me to check that the examples work properly).

Perhaps it would be best to reopen this PR when it is implemented in at least one browser?

@romulocintra romulocintra marked this pull request as draft March 23, 2022 10:46
@romulocintra
Copy link
Contributor Author

@romulocintra , sorry to be so slow getting to this PR. It looks like this isn't implemented anywhere yet, so I'm not sure we are ready to have docs on MDN for it (also it's hard, for example, for me to check that the examples work properly).

Perhaps it would be best to reopen this PR when it is implemented in at least one browser?

Converted it to Draft, as soon we have an implementation will re-open it. thanks @wbamberg

cc @sffc

@Josh-Cena Josh-Cena added the on hold Waiting on something else before this can be moved forward. label Aug 9, 2022
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

I'm so excited to see this work getting closer to being ready to be merged as soon as a browser implements this feature. So, I went ahead with a first pass of reviews.

To save you time, I crafted suggestions for most comments:

  • These are primarily typographic corrections.
  • I also fixed some details to prevent our linters (Markdownlint, Prettier) from complaining.
  • I removed Tags: as we removed them from the whole of MDN since the first version of this PR.
  • I added page-type: instead, as this is what replaced them.

There will be a second pass later, but that way, all these typographic thingies won't get in the way.

Thanks a lot for your work.

romulocintra and others added 3 commits March 9, 2023 09:51
…ionformat/durationformat/index.md

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
…ionformat/durationformat/index.md

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
…ionformat/durationformat/index.md

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
romulocintra and others added 8 commits March 9, 2023 09:51
…ionformat/durationformat/index.md

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
…ionformat/durationformat/index.md

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
…ionformat/durationformat/index.md

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
…ionformat/durationformat/index.md

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
…ionformat/durationformat/index.md

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
…ionformat/durationformat/index.md

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
…ionformat/durationformat/index.md

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Updates based on feedback , thanks to @teoli2003

Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
@romulocintra
Copy link
Contributor Author

Nice job!

I'm so excited to see this work getting closer to being ready to be merged as soon as a browser implements this feature. So, I went ahead with a first pass of reviews.

To save you time, I crafted suggestions for most comments:

  • These are primarily typographic corrections.
  • I also fixed some details to prevent our linters (Markdownlint, Prettier) from complaining.
  • I removed Tags: as we removed them from the whole of MDN since the first version of this PR.
  • I added page-type: instead, as this is what replaced them.

There will be a second pass later, but that way, all these typographic thingies won't get in the way.

Thanks a lot for your work.

Thanks you for such detailed review at 1st pass and all suggestions

Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is implemented in Safari 16.4, and these docs look comparable to other Intl pages in terms of structure and content, so I think it's near ready to go.

@Josh-Cena Josh-Cena removed the on hold Waiting on something else before this can be moved forward. label Mar 30, 2023
@Josh-Cena Josh-Cena changed the title Intl.Duration Format - MDN docs Reference for Intl.DurationFormat Mar 30, 2023
@teoli2003
Copy link
Contributor

@romulocintra When you bring this PR out of draft (meaning you think it is ready), we can merge it. Note that in case, we can always continue work in follow-ups.

@romulocintra romulocintra marked this pull request as ready for review March 30, 2023 07:54
@teoli2003 teoli2003 merged commit 9f134e6 into mdn:main Mar 30, 2023
@teoli2003
Copy link
Contributor

\o/

@romulocintra
Copy link
Contributor Author

\o/

Thank you for following along, this was quite long journey thank you again

@Elchi3
Copy link
Member

Elchi3 commented Mar 30, 2023

Is there no supportedLocalesOf here like there is for the other Intl APIs?

@romulocintra
Copy link
Contributor Author

romulocintra commented Mar 30, 2023

Is there no supportedLocalesOf here like there is for the other Intl APIs?

Yes @Elchi3 , good catch, there is I'll prepare PR upcoming days for it - https://tc39.es/proposal-intl-duration-format/#sec-Intl.DurationFormat.supportedLocalesOf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:JS JavaScript docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants