-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference for Intl.DurationFormat #11817
Conversation
Preview URLs (6 pages)
Flaws (5)Note! 1 document with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
External URLs (1)URL:
(comment last updated: 2023-03-30 07:56:39) |
Still missing a few things but we can start reviewing
|
@romulocintra , sorry to be so slow getting to this PR. It looks like this isn't implemented anywhere yet, so I'm not sure we are ready to have docs on MDN for it (also it's hard, for example, for me to check that the examples work properly). Perhaps it would be best to reopen this PR when it is implemented in at least one browser? |
Converted it to Draft, as soon we have an implementation will re-open it. thanks @wbamberg cc @sffc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
I'm so excited to see this work getting closer to being ready to be merged as soon as a browser implements this feature. So, I went ahead with a first pass of reviews.
To save you time, I crafted suggestions for most comments:
- These are primarily typographic corrections.
- I also fixed some details to prevent our linters (Markdownlint, Prettier) from complaining.
- I removed
Tags:
as we removed them from the whole of MDN since the first version of this PR. - I added
page-type:
instead, as this is what replaced them.
There will be a second pass later, but that way, all these typographic thingies won't get in the way.
Thanks a lot for your work.
files/en-us/web/javascript/reference/global_objects/intl/durationformat/durationformat/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/intl/durationformat/durationformat/index.md
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/intl/durationformat/durationformat/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/intl/durationformat/durationformat/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/intl/durationformat/durationformat/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/intl/durationformat/durationformat/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/intl/durationformat/durationformat/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/intl/durationformat/durationformat/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/intl/durationformat/durationformat/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/javascript/reference/global_objects/intl/durationformat/durationformat/index.md
Outdated
Show resolved
Hide resolved
…ionformat/durationformat/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
…ionformat/durationformat/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
…ionformat/durationformat/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
…ionformat/durationformat/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
…ionformat/durationformat/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
…ionformat/durationformat/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
…ionformat/durationformat/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
…ionformat/durationformat/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
…ionformat/durationformat/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
…ionformat/durationformat/index.md Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Updates based on feedback , thanks to @teoli2003 Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Thanks you for such detailed review at 1st pass and all suggestions |
3d45cbe
to
e27a509
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is implemented in Safari 16.4, and these docs look comparable to other Intl
pages in terms of structure and content, so I think it's near ready to go.
@romulocintra When you bring this PR out of draft (meaning you think it is ready), we can merge it. Note that in case, we can always continue work in follow-ups. |
\o/ |
Thank you for following along, this was quite long journey thank you again |
Is there no |
Yes @Elchi3 , good catch, there is I'll prepare PR upcoming days for it - https://tc39.es/proposal-intl-duration-format/#sec-Intl.DurationFormat.supportedLocalesOf |
Summary
MDN Docs for https://github.com/tc39/proposal-intl-duration-format
Supporting details
Related issues
tc39/ecma402-mdn#22
Metadata