Adapt PresentationConnection API to new events structure #15185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adapts the PresentationConnection API to conform to the new events structure. Note: there are no MDN pages associated with this event, so there will be no corresponding content PR. Any broken MDN URLs in BCD have been removed.
queengooborg
added
the
data:api 🐇
foolip
approved these changes
Mar 4, 2022
| "support": { | ||
| "chrome": { | ||
| "version_added": "47" | ||
| "version_added": "50" |
There was a problem hiding this comment.
This doesn't match the parent interface and made me suspect that on* properties were missing while the events were actually supported, but per https://source.chromium.org/chromium/chromium/src/+/5458a1b5f82ef7a0d01fca7c7352cd7fe7ec5d9a the events and the properties were added together. PresentationConnectionCloseEvent is also marked as Chrome 50.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts the PresentationConnection API to conform to the new events structure.
Note: there are no MDN pages associated with this event, so there will be no corresponding content PR. Any broken MDN URLs in BCD have been removed.