Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt PresentationConnection API to new events structure #15185

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Adapt PresentationConnection API to new events structure #15185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 40 additions & 40 deletions api/PresentationConnection.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,16 +194,15 @@
}
}
},
"id": {
"close_event": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/PresentationConnection/id",
"spec_url": "https://w3c.github.io/presentation-api/#dom-presentationconnection-id",
"description": "<code>close</code> event",
"support": {
"chrome": {
"version_added": "47"
"version_added": "50"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't match the parent interface and made me suspect that on* properties were missing while the events were actually supported, but per https://source.chromium.org/chromium/chromium/src/+/5458a1b5f82ef7a0d01fca7c7352cd7fe7ec5d9a the events and the properties were added together. PresentationConnectionCloseEvent is also marked as Chrome 50.

},
"chrome_android": {
"version_added": "47"
"version_added": "50"
},
"edge": {
"version_added": "79"
Expand Down Expand Up @@ -234,10 +233,10 @@
"version_added": false
},
"opera": {
"version_added": "34"
"version_added": "37"
},
"opera_android": {
"version_added": "34"
"version_added": "37"
},
"safari": {
"version_added": false
Expand All @@ -259,9 +258,9 @@
}
}
},
"onclose": {
"connect_event": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/PresentationConnection/onclose",
"description": "<code>connect</code> event",
"support": {
"chrome": {
"version_added": "50"
Expand Down Expand Up @@ -323,15 +322,16 @@
}
}
},
"onconnect": {
"id": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/PresentationConnection/onconnect",
"mdn_url": "https://developer.mozilla.org/docs/Web/API/PresentationConnection/id",
"spec_url": "https://w3c.github.io/presentation-api/#dom-presentationconnection-id",
"support": {
"chrome": {
"version_added": "50"
"version_added": "47"
},
"chrome_android": {
"version_added": "50"
"version_added": "47"
},
"edge": {
"version_added": "79"
Expand Down Expand Up @@ -362,10 +362,10 @@
"version_added": false
},
"opera": {
"version_added": "37"
"version_added": "34"
},
"opera_android": {
"version_added": "37"
"version_added": "34"
},
"safari": {
"version_added": false
Expand All @@ -387,9 +387,9 @@
}
}
},
"onmessage": {
"message_event": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/PresentationConnection/onmessage",
"description": "<code>message</code> event",
"support": {
"chrome": {
"version_added": "47"
Expand Down Expand Up @@ -451,15 +451,16 @@
}
}
},
"onterminate": {
"send": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/PresentationConnection/onterminate",
"mdn_url": "https://developer.mozilla.org/docs/Web/API/PresentationConnection/send",
"spec_url": "https://w3c.github.io/presentation-api/#dom-presentationconnection-send",
"support": {
"chrome": {
"version_added": "50"
"version_added": "47"
},
"chrome_android": {
"version_added": "50"
"version_added": "47"
},
"edge": {
"version_added": "79"
Expand Down Expand Up @@ -490,10 +491,10 @@
"version_added": false
},
"opera": {
"version_added": "37"
"version_added": "34"
},
"opera_android": {
"version_added": "37"
"version_added": "34"
},
"safari": {
"version_added": false
Expand All @@ -515,10 +516,10 @@
}
}
},
"send": {
"state": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/PresentationConnection/send",
"spec_url": "https://w3c.github.io/presentation-api/#dom-presentationconnection-send",
"mdn_url": "https://developer.mozilla.org/docs/Web/API/PresentationConnection/state",
"spec_url": "https://w3c.github.io/presentation-api/#dom-presentationconnection-state",
"support": {
"chrome": {
"version_added": "47"
Expand Down Expand Up @@ -580,16 +581,16 @@
}
}
},
"state": {
"terminate": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/PresentationConnection/state",
"spec_url": "https://w3c.github.io/presentation-api/#dom-presentationconnection-state",
"mdn_url": "https://developer.mozilla.org/docs/Web/API/PresentationConnection/terminate",
"spec_url": "https://w3c.github.io/presentation-api/#dom-presentationconnection-terminate",
"support": {
"chrome": {
"version_added": "47"
"version_added": "48"
},
"chrome_android": {
"version_added": "47"
"version_added": "48"
},
"edge": {
"version_added": "79"
Expand Down Expand Up @@ -620,10 +621,10 @@
"version_added": false
},
"opera": {
"version_added": "34"
"version_added": "35"
},
"opera_android": {
"version_added": "34"
"version_added": "35"
},
"safari": {
"version_added": false
Expand All @@ -645,16 +646,15 @@
}
}
},
"terminate": {
"terminate_event": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/PresentationConnection/terminate",
"spec_url": "https://w3c.github.io/presentation-api/#dom-presentationconnection-terminate",
"description": "<code>terminate</code> event",
"support": {
"chrome": {
"version_added": "48"
"version_added": "50"
},
"chrome_android": {
"version_added": "48"
"version_added": "50"
},
"edge": {
"version_added": "79"
Expand Down Expand Up @@ -685,10 +685,10 @@
"version_added": false
},
"opera": {
"version_added": "35"
"version_added": "37"
},
"opera_android": {
"version_added": "35"
"version_added": "37"
},
"safari": {
"version_added": false
Expand Down