Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update length BCD table for new viewport-percentage units #16449

Merged
merged 4 commits into from
May 31, 2022
Merged

Update length BCD table for new viewport-percentage units #16449

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c1e912f
Update length bcd for new viewport-percentage units
May 27, 2022
1e02542
Fix review comments
May 30, 2022
50e51a1
Reordered units to be in alphabetical order
May 30, 2022
a924108
Update experimental and standard status for units lh and rlh
May 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
160 changes: 151 additions & 9 deletions css/types/length.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,8 +340,8 @@
}
},
"status": {
"experimental": false,
"standard_track": true,
"experimental": true,
"standard_track": false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lh unit is defined in https://drafts.csswg.org/css-values/#lh

"deprecated": false
}
}
Expand Down Expand Up @@ -438,8 +438,8 @@
}
},
"status": {
"experimental": false,
"standard_track": true,
"experimental": true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dipikabh FYI this is better. Note though that normally we don't record things in BCD unless there is some implementation, so (even though this predates you) @queengooborg may suggest you remove the whole entry.

"standard_track": false,
"deprecated": false
}
}
Expand All @@ -458,11 +458,10 @@
"version_added": false
},
"firefox": {
"version_added": false,
"notes": "See <a href='https://bugzil.la/1287034'>bug 1287034</a>."
"version_added": "101"
},
"firefox_android": {
"version_added": false
"version_added": "101"
},
"ie": {
"version_added": false
Expand Down Expand Up @@ -557,12 +556,155 @@
"version_added": false
},
"firefox": {
"version_added": false,
"notes": "See <a href='https://bugzil.la/1287034'>bug 1287034</a>."
"version_added": "101"
},
"firefox_android": {
"version_added": "101"
},
"ie": {
"version_added": false
},
"opera": {
"version_added": false
},
"opera_android": {
"version_added": false
},
"safari": {
"version_added": "15.4"
},
"safari_ios": {
"version_added": "15.4"
},
"samsunginternet_android": {
"version_added": false
},
"webview_android": {
"version_added": false
}
},
"status": {
"experimental": false,
"standard_track": true,
"deprecated": false
}
}
},
"viewport_percentage_units_dynamic": {
"__compat": {
"description": "<code>dvb</code>, <code>dvh</code>, <code>dvi</code>, <code>dvmax</code>, <code>dvmin</code>, <code>dvw</code> units",
"support": {
"chrome": {
"version_added": false
},
"chrome_android": {
"version_added": false
},
"edge": {
"version_added": false
},
"firefox": {
"version_added": "101"
},
"firefox_android": {
"version_added": "101"
},
"ie": {
"version_added": false
},
"opera": {
"version_added": false
},
"opera_android": {
"version_added": false
},
"safari": {
"version_added": "15.4"
},
"safari_ios": {
"version_added": "15.4"
},
"samsunginternet_android": {
"version_added": false
},
"webview_android": {
"version_added": false
}
},
"status": {
"experimental": false,
"standard_track": true,
"deprecated": false
}
}
},
"viewport_percentage_units_large": {
"__compat": {
"description": "<code>lvb</code>, <code>lvh</code>, <code>lvi</code>, <code>lvmax</code>, <code>lvmin</code>, <code>lvw</code> units",
"support": {
"chrome": {
"version_added": false
},
"chrome_android": {
"version_added": false
},
"edge": {
"version_added": false
},
"firefox": {
"version_added": "101"
},
"firefox_android": {
"version_added": "101"
},
"ie": {
"version_added": false
},
"opera": {
"version_added": false
},
"opera_android": {
"version_added": false
},
"safari": {
"version_added": "15.4"
},
"safari_ios": {
"version_added": "15.4"
},
"samsunginternet_android": {
"version_added": false
},
"webview_android": {
"version_added": false
}
},
"status": {
"experimental": false,
"standard_track": true,
"deprecated": false
}
}
},
"viewport_percentage_units_small": {
"__compat": {
"description": "<code>svb</code>, <code>svh</code>, <code>svi</code>, <code>svmax</code>, <code>svmin</code>, <code>svw</code> units",
"support": {
"chrome": {
"version_added": false
},
"chrome_android": {
"version_added": false
},
"edge": {
"version_added": false
},
"firefox": {
"version_added": "101"
},
"firefox_android": {
"version_added": "101"
},
"ie": {
"version_added": false
},
Expand Down