Update length BCD table for new viewport-percentage units #16449
Conversation
github-actions
bot
added
the
data:css 🎨
css/types/length.json
Outdated
| }, | ||
| "firefox_android": { | ||
| "version_added": false | ||
| "version_added": "19", |
There was a problem hiding this comment.
Version 19? Is that correct /where does it come from?
css/types/length.json
Outdated
| "version_added": false, | ||
| "notes": "See <a href='https://bugzil.la/1287034'>bug 1287034</a>." | ||
| "version_added": "101", | ||
| "notes": "Starting with version 21, viewport-percentage lengths are invalid in <code>@page</code>." |
There was a problem hiding this comment.
What does this mean? i.e. specifically, this comes in at version 101 so why a note about version 21? (everywhere this appears)?
|
@queengooborg FYI CanIuse seems to think these new values implemented behind a flag on chrome too https://caniuse.com/viewport-unit-variants - also it gets mentioned on twitter: https://twitter.com/jensimmons/status/1499441043930062854?lang=en But I can't find a chrome status on this. Do we need to verify with test code or we ignore for now? |
|
Thanks @hamishwillee for catching the errors (and the unnecessary note) - they were all clear oversight on my part. |
|
@queengooborg, aside from the changes for the new viewport-percentage units, I just updated the table for the older units |
| @@ -438,8 +438,8 @@ | |||
| } | |||
| }, | |||
| "status": { | |||
| "experimental": false, | |||
| "standard_track": true, | |||
| "experimental": true, | |||
There was a problem hiding this comment.
@dipikabh FYI this is better. Note though that normally we don't record things in BCD unless there is some implementation, so (even though this predates you) @queengooborg may suggest you remove the whole entry.
|
Looks great to me, modulo maybe the need to add Chrome (behind flag) and perhaps deleting the features with no implementations. @queengooborg When you have a chance ... |
| "experimental": false, | ||
| "standard_track": true, | ||
| "experimental": true, | ||
| "standard_track": false, |
There was a problem hiding this comment.
The lh unit is defined in https://drafts.csswg.org/css-values/#lh
Summary
Each can be of the type s, l, d resulting in:
dvb, dvh, dvi, dvmax, dvmin, dvw,
lvb, lvh, lvi, lvmax, lvmin, lvw,
svb, svh, svi, svmax, svmin, svw
Test results and supporting details
https://bugzilla.mozilla.org/show_bug.cgi?id=1610815
Related issues
Doc issue tracking this work: mdn/content#15465
Comment reference: mdn/content#15465 (comment)