Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demix transition events from GlobalEventHandlers #16758

Merged
merged 15 commits into from
Jul 14, 2022

Conversation

queengooborg
Copy link
Contributor

This PR demixes the transition events from the GlobalEventHandlers mixin. There was a lot of inconsistency in the original data, a resolution was attempted here.

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 21, 2022
@queengooborg queengooborg added the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jun 21, 2022
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be very similar to #16531. Can you move the entries to Element and remove everything else?

api/Element.json Outdated Show resolved Hide resolved
api/Element.json Outdated Show resolved Hide resolved
api/Element.json Outdated Show resolved Hide resolved
api/Element.json Outdated Show resolved Hide resolved
api/Element.json Outdated Show resolved Hide resolved
api/Element.json Outdated Show resolved Hide resolved
api/Element.json Outdated Show resolved Hide resolved
api/Element.json Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

queengooborg and others added 3 commits July 9, 2022 22:45
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

api/Element.json Outdated
{
"version_added": "12",
"partial_implementation": true,
"notes": "The event handler exists but will never be called."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you match the wording we have elsewhere? "Although the onmessageerror property is supported, the messageerror event is never fired. See bug 171216."

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

"__compat": {
"description": "<code>transitionend</code> event",
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Element/transitionend_event",
"spec_url": "https://drafts.csswg.org/css-transitions/#transitionend",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one spec URL here? Can you do the same as above?

api/Element.json Outdated Show resolved Hide resolved
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
@queengooborg queengooborg merged commit fe66b60 into mdn:main Jul 14, 2022
@queengooborg queengooborg removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jul 14, 2022
@foolip
Copy link
Contributor

foolip commented Jul 14, 2022

@queengooborg there were comments not resolved yet in #16758 (comment)

@queengooborg queengooborg deleted the api/GlobalEventHandlers/transition branch July 14, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants