-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demix transition events from GlobalEventHandlers #16758
Demix transition events from GlobalEventHandlers #16758
Conversation
This pull request has merge conflicts that must be resolved before it can be merged. |
This pull request has merge conflicts that must be resolved before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be very similar to #16531. Can you move the entries to Element
and remove everything else?
This pull request has merge conflicts that must be resolved before it can be merged. |
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
This pull request has merge conflicts that must be resolved before it can be merged. |
This pull request has merge conflicts that must be resolved before it can be merged. |
api/Element.json
Outdated
{ | ||
"version_added": "12", | ||
"partial_implementation": true, | ||
"notes": "The event handler exists but will never be called." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you match the wording we have elsewhere? "Although the onmessageerror
property is supported, the messageerror
event is never fired. See bug 171216."
This pull request has merge conflicts that must be resolved before it can be merged. |
"__compat": { | ||
"description": "<code>transitionend</code> event", | ||
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Element/transitionend_event", | ||
"spec_url": "https://drafts.csswg.org/css-transitions/#transitionend", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one spec URL here? Can you do the same as above?
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
@queengooborg there were comments not resolved yet in #16758 (comment) |
This PR demixes the
transition
events from the GlobalEventHandlers mixin. There was a lot of inconsistency in the original data, a resolution was attempted here.