Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demix transition events from GlobalEventHandlers #18312

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Demix transition events from GlobalEventHandlers #18312

merged 1 commit into from
Jul 14, 2022

Conversation

queengooborg
Copy link
Collaborator

This PR demixes the transition event handlers from the GlobalEventHandlers mixin. Related BCD PR: mdn/browser-compat-data#16758

@queengooborg queengooborg requested review from a team as code owners July 13, 2022 12:29
@queengooborg queengooborg requested review from Rumyra and removed request for a team July 13, 2022 12:29
@github-actions github-actions bot added Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs labels Jul 13, 2022
@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Mozilla/Firefox/Releases/53
Title: Firefox 53 for developers
on GitHub
Flaw count: 12

  • macros:
    • /en-US/docs/Web/API/HTMLElement/transitionstart_event redirects to /en-US/docs/Web/API/Element/transitionstart_event
    • /en-US/docs/Web/API/HTMLElement/transitionrun_event redirects to /en-US/docs/Web/API/Element/transitionrun_event
    • /en-US/docs/Web/API/HTMLElement/transitioncancel_event redirects to /en-US/docs/Web/API/Element/transitioncancel_event
    • /en-US/docs/Web/API/HTMLElement/transitioncancel_event redirects to /en-US/docs/Web/API/Element/transitioncancel_event
    • /en-US/docs/Web/API/HTMLHyperLinkElementUtils does not exist
    • and 3 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/Transferable
    • Can't resolve /en-US/docs/Mozilla/Gecko/Chrome/API/Browser_API
    • Can't resolve /en-US/docs/Archive/B2G_OS/API/WiFi_Information_API
    • Can't resolve /en-US/docs/Archive/B2G_OS/API/Settings_API

URL: /en-US/docs/Mozilla/Firefox/Releases/51
Title: Firefox 51 for developers
on GitHub
Flaw count: 23

  • macros:
    • /en-US/docs/Web/API/SVGElement/dataset redirects to /en-US/docs/Web/API/HTMLElement/dataset
    • /en-US/docs/Web/API/WorkerGlobalScope/onclose redirects to /en-US/docs/Web/API/DedicatedWorkerGlobalScope/close
    • /en-US/docs/Web/API/Worker/importScripts does not exist
    • /en-US/docs/Web/API/NavigatorStorage/storage redirects to /en-US/docs/Web/API/Navigator/storage
    • /en-US/docs/Web/API/Element/onanimationstart does not exist
    • and 4 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Web/JavaScript/Reference/Statements/for_each...in
    • Can't resolve /en-US/docs/Web/JavaScript/Reference/Errors/For-each-in_loops_are_deprecated
    • Can't resolve /en-US/docs/Web/JavaScript/Reference/Statements/Legacy_generator_function
    • Can't resolve /en-US/docs/Mozilla/Projects/Necko/Proxy_Auto-Configuration_(PAC)_file
    • Can't resolve /en-US/docs/Archive/Firefox_OS/API/Simple_Push_API
    • and 9 more flaws omitted

URL: /en-US/docs/Web/API/Element/transitionrun_event
Title: Element: transitionrun event
on GitHub
Flaw count: 5

  • macros:
    • /en-US/docs/Web/API/GlobalEventHandlers/ontransitionrun does not exist
    • /en-US/docs/Web/API/Document/transitionrun_event redirects to /en-US/docs/Web/API/Element/transitionrun_event
    • /en-US/docs/Web/API/Window/transitionrun_event redirects to /en-US/docs/Web/API/Element/transitionrun_event
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/GlobalEventHandlers/ontransitionrun
  • bad_bcd_queries:
    • No BCD data for query: api.Element.transitionrun_event

URL: /en-US/docs/Web/API/Element/transitionend_event
Title: Element: transitionend event
on GitHub
Flaw count: 6

  • macros:
    • /en-US/docs/Web/API/GlobalEventHandlers/ontransitionend redirects to /en-US/docs/Web/API/Element/transitionend_event
    • /en-US/docs/Web/API/GlobalEventHandlers/ontransitionend redirects to /en-US/docs/Web/API/Element/transitionend_event
    • /en-US/docs/Web/API/Document/transitionend_event redirects to /en-US/docs/Web/API/Element/transitionend_event
    • /en-US/docs/Web/API/Window/transitionend_event redirects to /en-US/docs/Web/API/Element/transitionend_event
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/Window/transitioncancel_event
  • bad_bcd_queries:
    • No BCD data for query: api.Element.transitionend_event

URL: /en-US/docs/Web/API/Element/transitioncancel_event
Title: Element: transitioncancel event
on GitHub
Flaw count: 5

  • macros:
    • /en-US/docs/Web/API/Document/transitioncancel_event redirects to /en-US/docs/Web/API/Element/transitioncancel_event
    • /en-US/docs/Web/API/Window/transitioncancel_event redirects to /en-US/docs/Web/API/Element/transitioncancel_event
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/Window/transitioncancel_event
    • Can't resolve /en-US/docs/Web/API/Window/transitionend_event
  • bad_bcd_queries:
    • No BCD data for query: api.Element.transitioncancel_event

URL: /en-US/docs/Web/API/Element/transitionstart_event
Title: Element: transitionstart event
on GitHub
Flaw count: 5

  • macros:
    • /en-US/docs/Web/API/GlobalEventHandlers/ontransitionstart does not exist
    • /en-US/docs/Web/API/Document/transitionstart_event redirects to /en-US/docs/Web/API/Element/transitionstart_event
    • /en-US/docs/Web/API/Window/transitionstart_event redirects to /en-US/docs/Web/API/Element/transitionstart_event
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/GlobalEventHandlers/ontransitionstart
  • bad_bcd_queries:
    • No BCD data for query: api.Element.transitionstart_event

URL: /en-US/docs/Web/API/GlobalEventHandlers
Title: GlobalEventHandlers
on GitHub
Flaw count: 73

  • macros:
    • /en-US/docs/Web/API/GlobalEventHandlers/onabort redirects to /en-US/docs/Web/API/HTMLMediaElement/abort_event
    • /en-US/docs/Web/API/GlobalEventHandlers/oncontextmenu redirects to /en-US/docs/Web/API/Element/contextmenu_event
    • /en-US/docs/Web/API/GlobalEventHandlers/onformdata redirects to /en-US/docs/Web/API/HTMLFormElement/formdata_event
    • /en-US/docs/Web/API/HTMLMediaElement/loadend_event does not exist
    • /en-US/docs/Web/API/GlobalEventHandlers/onprogress does not exist
    • and 9 more flaws omitted
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 54 more flaws omitted

External URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/53
Title: Firefox 53 for developers
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Firefox/Releases/51
Title: Firefox 51 for developers
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Element/transitionrun_event
Title: Element: transitionrun event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Element/transitionend_event
Title: Element: transitionend event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Element/transitioncancel_event
Title: Element: transitioncancel event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Element/transitionstart_event
Title: Element: transitionstart event
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/GlobalEventHandlers
Title: GlobalEventHandlers
on GitHub

No external URLs

teoli2003
teoli2003 approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teoli2003 teoli2003 merged commit 38b0a09 into mdn:main Jul 14, 2022
@queengooborg queengooborg deleted the ontransition branch July 14, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@Rumyra Rumyra Awaiting requested review from Rumyra Rumyra is a code owner automatically assigned from mdn/yari-content-web-api

Assignees
No one assigned
Labels
Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @teoli2003