Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compat data for MutationObserver #2094

Merged
merged 3 commits into from
Jun 28, 2018
Merged

Add compat data for MutationObserver #2094

merged 3 commits into from
Jun 28, 2018

Conversation

bunnybooboo
Copy link
Contributor

@Elchi3 Elchi3 added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label May 22, 2018
ExE-Boss
ExE-Boss suggested changes Jun 27, 2018
View reviewed changes
Copy link
Contributor

@ExE-Boss ExE-Boss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to see this merged before version 0.0.40 alongside #2299, but that means that the following has to be addressed first:

api/MutationObserver.json Outdated
"support": {
"webview_android": {
"version_added": null
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be:

"webview_android": [
  {
    "version_added": "26"
  },
  {
    "version_added": "18",
    "version_removed": "26",
    "prefix": "Webkit"
  }
]

And moved to the end of the support block (see #398 and #1882).

api/MutationObserver.json Outdated
{
"version_added": "6",
"version_removed": "7",
"notes": "Prefixed with <code>-webkit</code>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be:

"safari_ios": [
  {
    "version_added": "7"
  },
  {
    "version_added": "6",
    "version_removed": "7",
    "prefix": "Webkit"
  }
]

api/MutationObserver.json Outdated
}
],
"samsunginternet_android": {
"version_added": null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true

api/MutationObserver.json Outdated
"status": {
"experimental": false,
"standard_track": true,
"deprecated": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

false

api/MutationObserver.json Outdated
"support": {
"webview_android": {
"version_added": null
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be:

"webview_android": [
  {
    "version_added": "26"
  },
  {
    "version_added": "18",
    "version_removed": "26",
    "prefix": "Webkit"
  }
]

And moved to the end of the support block (see #398 and #1882).

api/MutationObserver.json Outdated
"opera_android": {
"version_added": "15"
},
"safari": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be:

"safari": {
  "version_added": "7"
}

api/MutationObserver.json Outdated
"version_added": "7"
}
],
"safari_ios": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be:

"safari_ios": {
  "version_added": "7"
}

api/MutationObserver.json Outdated
}
],
"samsunginternet_android": {
"version_added": null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true

api/MutationObserver.json Outdated
"status": {
"experimental": false,
"standard_track": true,
"deprecated": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

false

api/MutationObserver.json Outdated
}
}
},
"MutationObserverInit": {
Copy link
Contributor

@ExE-Boss ExE-Boss Jun 27, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been done by #2299 in a much better way by @a2sheppy, so remove this.

@Elchi3
Copy link
Member

Elchi3 commented Jun 28, 2018

I've updated this, thank you for the review @ExE-Boss! Let me know if this looks good now and I'll merge it before I release 0.0.40 later this evening.

ExE-Boss
ExE-Boss reviewed Jun 28, 2018
View reviewed changes
Copy link
Contributor

@ExE-Boss ExE-Boss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Elchi3 Just a few details left to fix, and it’s good.

(I should’ve noticed my mistake with the latter 2 Safari ones)

api/MutationObserver.json Outdated
"version_added": "15"
},
"safari": {
"version_added": "7"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was 6.

api/MutationObserver.json Outdated
"version_added": "7"
},
"safari_ios": {
"version_added": "7"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was 6.

api/MutationObserver.json Outdated
"version_added": "15"
},
"safari": {
"version_added": "7"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was 6.

api/MutationObserver.json Outdated
"version_added": "7"
},
"safari_ios": {
"version_added": "7"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was 6.

api/MutationObserver.json Outdated
"version_added": "15"
},
"opera_android": {
"version_added": "15"
Copy link
Contributor

@ExE-Boss ExE-Boss Jun 28, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opera Android began using WebKit/Blink with version 14, 1 version before Opera for Desktop.

api/MutationObserver.json Outdated
"version_added": "15"
},
"opera_android": {
"version_added": "15"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

api/MutationObserver.json Outdated
"version_added": "15"
},
"opera_android": {
"version_added": "15"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

api/MutationObserver.json Outdated
"version_added": "15"
},
"opera_android": {
"version_added": "15"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opera Android began using WebKit/Blink with version 14, 1 version before Opera for Desktop.

api/MutationObserver.json Outdated
"version_added": "15"
},
"opera_android": {
"version_added": "15"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opera Android began using WebKit/Blink with version 14, 1 version before Opera for Desktop.

@Elchi3
Copy link
Member

Elchi3 commented Jun 28, 2018

Well spotted, thanks again!

ExE-Boss
ExE-Boss approved these changes Jun 28, 2018
View reviewed changes
Copy link
Contributor

@ExE-Boss ExE-Boss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r+

@Elchi3 Elchi3 merged commit 3c135e8 into mdn:master Jun 28, 2018
germain-gg pushed a commit to germain-gg/browser-compat-data that referenced this pull request Jun 29, 2018
Merge branch 'master' into positionoptions
0e9e5a0 
* master: (175 commits)
  Add Server-Timing header (mdn#2148)
  40th alpha version
  Add compat data for input-password (mdn#2235)
  Add addTransceiver() method for RTCPeerConnection. (mdn#2311)
  Update Payments API for Chrome. (mdn#2378)
  Add compat data for MutationObserver (mdn#2094)
  Fix compat data for "let" in Chrome (mdn#1632)
  Safari has more formdata support now (mdn#2376)
  Add compat data for Window sub features from A to F (mdn#2109)
  Add guidelines around worker support and constructors for API subfeatures (mdn#2373)
  Update place-content.json (mdn#2240)
  Add compat data for HTMLDetailsElement (mdn#2315)
  Add compat data for input-month (mdn#2204)
  Add compat data to input-week (mdn#2230)
  Add compat data for input-radio (mdn#2208)
  Add compat data for input-tel (mdn#2226)
  Add compat data for input-image (mdn#2207)
  Add compat data for input-number (mdn#2206)
  Add compat data for input-hidden (mdn#2203)
  Add compat data for input-file (mdn#2202)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ExE-Boss ExE-Boss ExE-Boss approved these changes

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bunnybooboo @Elchi3 @ExE-Boss