Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compat data to input-week #2230

Merged
merged 3 commits into from
Jun 27, 2018
Merged

Add compat data to input-week #2230

merged 3 commits into from
Jun 27, 2018

Conversation

maboa
Copy link
Contributor

@maboa maboa commented Jun 7, 2018

@Elchi3 Elchi3 added the data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Jun 7, 2018
ddbeck
ddbeck previously requested changes Jun 22, 2018
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @maboa. Needs a description and an adjustment to the Firefox notes and data, but it's close. Thank you!

},
"firefox": {
"version_added": false,
"notes": "This feature is not implemented yet. See <a href='https://bugzil.la/888320'>bug 888320</a> and <a href='https://wiki.mozilla.org/TPE_DOM/Date_time_input_types'>TPE DOM/Date time input types</a>."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is false for both desktop and Android Firefoxes and @wbamberg's comment on #2200 applies to both as well

"input": {
"input-week": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/html/Element/input/week",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs "description": "<code>type=\"week\"</code>"

@maboa
Copy link
Contributor Author

maboa commented Jun 25, 2018

This should be sorted now! Thanks :)

},
"firefox": {
"version_added": false,
"notes": "This feature is not implemented yet. See <a href='https://bugzil.la/888320'>bug 888320</a>."
Copy link
Collaborator

@ddbeck ddbeck Jun 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nit, sorry. Can we change this note to only "See <a href='https://bugzil.la/888320'>bug 888320</a>." Thank you, @maboa!

@Elchi3 Elchi3 dismissed ddbeck’s stale review June 27, 2018 11:11

Tweaked the note

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mark and Daniel! 👍

@Elchi3 Elchi3 merged commit 30b4ddc into mdn:master Jun 27, 2018
germain-gg pushed a commit to germain-gg/browser-compat-data that referenced this pull request Jun 29, 2018
* master: (175 commits)
  Add Server-Timing header (mdn#2148)
  40th alpha version
  Add compat data for input-password (mdn#2235)
  Add addTransceiver() method for RTCPeerConnection. (mdn#2311)
  Update Payments API for Chrome. (mdn#2378)
  Add compat data for MutationObserver (mdn#2094)
  Fix compat data for "let" in Chrome (mdn#1632)
  Safari has more formdata support now (mdn#2376)
  Add compat data for Window sub features from A to F (mdn#2109)
  Add guidelines around worker support and constructors for API subfeatures (mdn#2373)
  Update place-content.json (mdn#2240)
  Add compat data for HTMLDetailsElement (mdn#2315)
  Add compat data for input-month (mdn#2204)
  Add compat data to input-week (mdn#2230)
  Add compat data for input-radio (mdn#2208)
  Add compat data for input-tel (mdn#2226)
  Add compat data for input-image (mdn#2207)
  Add compat data for input-number (mdn#2206)
  Add compat data for input-hidden (mdn#2203)
  Add compat data for input-file (mdn#2202)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants