Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for Chrome 123 beta #22280

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Updates for Chrome 123 beta #22280

merged 2 commits into from
Mar 4, 2024

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Feb 22, 2024

The Open Web Docs BCD collector v10.8.0 found new features shipping in Chrome 123 beta which was released yesterday. Currently, the collector covers about 88% of BCD, so the following list might not be exhaustive. Also, if a feature is in Chrome Canary/behind origin trials/enrollment, it is not considered here.

With this PR, BCD considers the following features as shipping in Chrome 123:

  • api.CSSKeyframesRule.length
  • api.Navigation.activation
  • api.NavigationActivation
  • api.NavigationActivation.entry
  • api.NavigationActivation.from
  • api.NavigationActivation.navigationType
  • api.PageRevealEvent
  • api.PerformanceLongAnimationFrameTiming
  • api.PerformanceLongAnimationFrameTiming.blockingDuration
  • api.PerformanceLongAnimationFrameTiming.firstUIEventTimestamp
  • api.PerformanceLongAnimationFrameTiming.renderStart
  • api.PerformanceLongAnimationFrameTiming.scripts
  • api.PerformanceLongAnimationFrameTiming.styleAndLayoutStart
  • api.PerformanceLongAnimationFrameTiming.toJSON
  • api.PerformanceScriptTiming
  • api.PerformanceScriptTiming.executionStart
  • api.PerformanceScriptTiming.forcedStyleAndLayoutDuration
  • api.PerformanceScriptTiming.invoker
  • api.PerformanceScriptTiming.invokerType
  • api.PerformanceScriptTiming.pauseDuration
  • api.PerformanceScriptTiming.toJSON
  • api.PerformanceScriptTiming.window
  • api.PerformanceScriptTiming.windowAttribution
  • css.properties.field-sizing
  • css.properties.field-sizing.content
  • css.properties.field-sizing.fixed
  • css.properties.paint-order
  • css.properties.text-spacing-trim
  • css.properties.text-spacing-trim.normal
  • css.properties.text-spacing-trim.space-all
  • css.properties.text-spacing-trim.space-first
  • css.properties.text-spacing-trim.trim-start
  • css.types.color.light-dark

I think all of this is in line with what https://chromestatus.com says currently.

Again, I hope this auto-generated PR is useful to update BCD for the new Chrome 123 more easily and faster. If you have feedback, let me know! /cc @chrisdavidmills

@github-actions github-actions bot added data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS labels Feb 22, 2024
Copy link
Collaborator

@rachelandrew rachelandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api.CSSKeyframesRule.length is in 124 https://chromestatus.com/feature/6289894144212992 otherwise all LGTM.

@Elchi3
Copy link
Member Author

Elchi3 commented Feb 26, 2024

api.CSSKeyframesRule.length is in 124 https://chromestatus.com/feature/6289894144212992 otherwise all LGTM.

https://chromiumdash.appspot.com/commit/a22c1207bb2c8ba2e6f88bb00c09062f980dd04f says it is shipping in Chrome 123. Is Chromestatus wrong?

@rachelandrew
Copy link
Collaborator

rachelandrew commented Feb 26, 2024 via email

@Elchi3
Copy link
Member Author

Elchi3 commented Feb 26, 2024

Thanks Rachel! Reverted the change to CSSKeyframesRule.length

Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged!

@queengooborg queengooborg merged commit df1bdab into mdn:main Mar 4, 2024
6 checks passed
@Elchi3 Elchi3 deleted the chrome-123-beta branch March 4, 2024 08:13
@foolip
Copy link
Collaborator

foolip commented Mar 27, 2024

api.CSSKeyframesRule.length is in 124 https://chromestatus.com/feature/6289894144212992 otherwise all LGTM.

The chromestatus entry is wrong, I'll update it and send a PR.

@foolip
Copy link
Collaborator

foolip commented Mar 27, 2024

In general I would assume chromestatus is wrong if it disagrees with collector results, but it's best to investigate a bit for the few cases where it's the other way around.

@Elchi3
Copy link
Member Author

Elchi3 commented Mar 27, 2024

Thanks @foolip! I'm usually skeptical with the data on chromestatus but in this case the data was freshly updated by the engineer working on the feature, so that seemed like a strong hint to me that chromestatus would be correct this time.

@foolip
Copy link
Collaborator

foolip commented Mar 27, 2024

@Elchi3 Sometimes it is right, yeah, the collector isn't perfect. Feel free to ping me to dig through source if you're not sure about a case, as long as I see the notification I can do it pretty quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants