Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Long Animation Frame Timing #645

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Conversation

Elchi3
Copy link
Collaborator

@Elchi3 Elchi3 commented Feb 23, 2024

Another example PR for bundles that could be exported to web-features when we run the OWD BCD collector for new browser versions and new features shipping with them: mdn/browser-compat-data#22280

I'm pretty sure a bundle for "Long Animation Frame Timing" makes sense.

For "Navigation Activation", I don't know if this part of something larger. It has its own entry on Chromestatus at least.

feature-group-definitions/long-animation-frame-timing.yaml Outdated Show resolved Hide resolved
@@ -0,0 +1,2 @@
name: Navigation Activation
spec: https://html.spec.whatwg.org/multipage/nav-history-apis.html#navigation-activation-interface
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Searching for "NavigationActivation" in the spec, the PageSwapEvent interface is also related, by having an activation member. But that's not in mdn/browser-compat-data#22280, was it not shipped together?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it hasn't shipped yet. PageSwapEvent builds on top of the NavigationActivation feature.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks for confirming!

feature-group-definitions/navigation-activation.yml Outdated Show resolved Hide resolved
@foolip
Copy link
Collaborator

foolip commented Feb 29, 2024

@natechapin @noamr as owners of https://chromestatus.com/feature/5076557983121408, can you weigh in on whether "navigation activation" should be consider a feature in its own right, or if it's a part of the Navigation API or some other feature?

@noamr
Copy link
Contributor

noamr commented Feb 29, 2024

@natechapin @noamr as owners of https://chromestatus.com/feature/5076557983121408, can you weigh in on whether "navigation activation" should be consider a feature in its own right, or if it's a part of the Navigation API or some other feature?

100% part of the navigation API.
It uses navigation-API existing interfaces like NavgationHistoryEntry and you access it via navigation.activation

@foolip
Copy link
Collaborator

foolip commented Feb 29, 2024

How about PageSwapEvent? That touches both navigation API and view transitions, but should it be said to be mainly part of one of those features? It's not a problem if it's correctly described as being part of two features at once, but it's not a situation we've had so far in web-features.

@noamr
Copy link
Contributor

noamr commented Mar 1, 2024

How about PageSwapEvent? That touches both navigation API and view transitions, but should it be said to be mainly part of one of those features? It's not a problem if it's correctly described as being part of two features at once, but it's not a situation we've had so far in web-features.

I'd say that it's in the neighborhood of PageTransitionEvent (pageshow/pagehide) and PageRevealEvent, and it links to the other features.

When we give an overview of view transitions we should link back there.

Co-authored-by: Philip Jägenstedt <philip@foolip.org>
@ddbeck ddbeck requested a review from foolip March 7, 2024 14:55
@foolip
Copy link
Collaborator

foolip commented Mar 7, 2024

I think the conclusion here is that Navigation Activation should be part of the Navigation API, at least in the long run. @Elchi3 can you drop that feature from this PR, and change the tag in BCD if one was already added?

@Elchi3 Elchi3 changed the title Add Long Animation Frame Timing + Navigation Activation Add Long Animation Frame Timing Mar 8, 2024
@@ -0,0 +1,2 @@
name: Long animation frame timing
spec: https://w3c.github.io/longtasks/#sec-loaf-timing
Copy link
Collaborator

@foolip foolip Mar 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, LOAF isn't an abbreviation acronym of Long Animation Frame.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's LoAF
Also Radar is not an exact acronym of (RAdio Detection And Ranging)

@foolip foolip merged commit ad93260 into web-platform-dx:main Mar 8, 2024
2 checks passed
@Elchi3 Elchi3 deleted the laof-na branch March 8, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants