Update SVG attribute data from null to false based on collector results #23129
Conversation
These are changes that the collector can make after this bugfix: openwebdocs/mdn-bcd-collector#1473
github-actions
bot
added
the
data:svg 🖌️
| @@ -43,12 +43,12 @@ | |||
| "spec_url": "https://svgwg.org/svg2-draft/struct.html#LangSpaceAttrs", | |||
| "support": { | |||
| "chrome": { | |||
| "version_added": null | |||
| "version_added": false | |||
There was a problem hiding this comment.
https://mdn-bcd-collector.gooborg.com/tests/svg/global_attributes/lang looks to me like an invalid test for this. It's looking for a lang property, but there is no lang IDL attribute on SVGElement or any subinterface.
There was a problem hiding this comment.
Hmm...if there isn't a matching IDL attribute, what's our best way to test this?
There was a problem hiding this comment.
I don't think the lang attribute has any observable effect to a web developer, but perhaps it affects the accessibility tree. But testing ancient browsers with ancient screen readers to figure this out doesn't seem justified.
I think we can set these versions to the earliest version that SVG was supported at all.
| @@ -760,12 +760,12 @@ | |||
| "spec_url": "https://www.w3.org/TR/SVG11/struct.html#RequiredFeaturesAttribute", | |||
| "support": { | |||
| "chrome": { | |||
| "version_added": null | |||
| "version_added": false | |||
There was a problem hiding this comment.
https://mdn-bcd-collector.gooborg.com/tests/svg/global_attributes/requiredFeatures also seems invalid, there is no requiredFeatures IDL attribute.
| @@ -794,12 +794,12 @@ | |||
| "spec_url": "https://svgwg.org/svg2-draft/struct.html#ConditionalProcessingSystemLanguageAttribute", | |||
| "support": { | |||
| "chrome": { | |||
| "version_added": null | |||
| "version_added": false | |||
There was a problem hiding this comment.
This is defined in https://svgwg.org/svg2-draft/types.html#InterfaceSVGTests but https://mdn-bcd-collector.gooborg.com/tests/svg/global_attributes/systemLanguage is invalid because it's looking for the property on a generic SVGElement, but but the IDL attribute is on SVGAnimationElement and SVGGraphicsElement.
| @@ -902,12 +902,12 @@ | |||
| "spec_url": "https://drafts.fxtf.org/css-masking/#clip-property", | |||
| "support": { | |||
| "chrome": { | |||
| "version_added": null | |||
| "version_added": false | |||
There was a problem hiding this comment.
No spec defines a clip IDL attribute so https://mdn-bcd-collector.gooborg.com/tests/svg/global_attributes/clip is invalid I think.
|
I've gone through about half of the changes and found that the tests are invalid. I'll mark this draft and file an issue on the collector instead. |
|
I have sent openwebdocs/mdn-bcd-collector#1474. |
|
Closing this given openwebdocs/mdn-bcd-collector#1474 and other fixes. |
These are changes that the collector can make after this bugfix:
openwebdocs/mdn-bcd-collector#1473