Remove invalid SVG global attribute tests #1474
Conversation
| "id", | ||
| "kerning", | ||
| "lang", |
There was a problem hiding this comment.
lang is listed in https://svgwg.org/svg2-draft/struct.html#CommonAttributes but I think it's actually not possible to test because there is no reflected IDL attributes.
|
It would be good to move these attributes to their relevant elements. If you don't feel like doing that in this PR then it would be good to at least file an issue. Seems like BCD should also move them from global attributes to specific attributes under the elements. |
For most of these, there is no IDL attribute defined by SVG or any other spec (such as filter effects) and no browser seems to have them as non-standard extensions. A few of these do however have IDL attributes defined, but in mixins that are included by specific SVG elements interfaces: href: https://svgwg.org/svg2-draft/types.html#InterfaceSVGURIReference requiredExtensions: https://svgwg.org/svg2-draft/types.html#InterfaceSVGTests systemLanguage: https://svgwg.org/svg2-draft/types.html#InterfaceSVGTests textLength is only for SVGTextContentElement. transform is only for SVGGraphicsElement. The removed tests all fail in Chrome, Firefox and Safari. The remaining 4 tests all pass.
foolip
force-pushed
the
svg-global-attributes
branch
from
327efdd
to
09745b6
Compare
I agree that having tests for SVG attribute support would be good. It's not that I don't feel like it, but it seems the necessary first step is a very big one: untangle all SVG attribute data and decide what should and shouldn't be a global attribute. mdn/browser-compat-data#9462 is a good issue about that. |
For most of these, there is no IDL attribute defined by SVG or any other
spec (such as filter effects) and no browser seems to have them as
non-standard extensions.
A few of these do however have IDL attributes defined, but in mixins
that are included by specific SVG elements interfaces:
href: https://svgwg.org/svg2-draft/types.html#InterfaceSVGURIReference
requiredExtensions: https://svgwg.org/svg2-draft/types.html#InterfaceSVGTests
systemLanguage: https://svgwg.org/svg2-draft/types.html#InterfaceSVGTests
textLength is only for SVGTextContentElement.
transform is only for SVGGraphicsElement.
The removed tests all fail in Chrome, Firefox and Safari. The remaining
4 tests all pass.