Add json schema data to the .vscode/settings.json file. #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @ExE-Boss I figure you might be interested in trying this out :) |
Elchi3
added
the
infra
Elchi3
approved these changes
Oct 4, 2018
There was a problem hiding this comment.
I just tried this and it is working nicely, thank you for this @connorshea 👍
display property descriptions (which the schemas don't currently have, but they could be added if we want them)
I think this is #309, right?
|
Yep, that’d be it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change to
.vscode/settings.json, VS Code will automatically point out errors with the current JSON file based on the schema. It'll also make the editor auto-suggest properties, display property descriptions (which the schemas don't currently have, but they could be added if we want them) and other nice things.Value isn't accepted, lists accepted values:
An example of how descriptions would work if we added them to the schema:
A list of missing, required properties:
The list of properties that could be added (I used the command palette's "Trigger Suggest" function to show this, not sure how you'd get this to show otherwise):
What happens when you have a URL that doesn't match the regex for
mdn_url:See also the relevant VS Code Documentation for this feature.