Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vscode): Add schema validation #583

Merged
merged 1 commit into from
Feb 4, 2020

Conversation

ExE-Boss
Copy link
Collaborator

@ExE-Boss ExE-Boss commented Feb 4, 2020

This makes it so that when viewing the files in Visual Studio Code, schema validation is performed automatically.

@tobie
Copy link
Owner

tobie commented Feb 4, 2020

I think I'll need to be convinced why that belongs in the project.

@ExE-Boss
Copy link
Collaborator Author

ExE-Boss commented Feb 4, 2020

@connorshea articulated the reasoning a lot better in mdn/browser-compat-data#2905 than I could.

@tobie
Copy link
Owner

tobie commented Feb 4, 2020

Oh, I get how it works. It's just dedicated to a specific editor, and so that's the part that requires argumentation. (I'm not saying I agree or disagree, I'm saying I need a convincing argument as to why that's OK.)

@marcoscaceres
Copy link
Collaborator

As a VS Code user, I definitely wouldn’t say no. It’s a nice thing that doesn’t get in the way*.

  • as long as it’s maintained.

@tobie
Copy link
Owner

tobie commented Feb 4, 2020

*as long as it’s maintained.

That was my concern, too!

@marcoscaceres
Copy link
Collaborator

marcoscaceres commented Feb 4, 2020

I like that it just points to our existing schema - so there is not really much to maintain. @ExE-Boss are you willing to maintain this long term (5 years, say) if we call on you?

@ExE-Boss
Copy link
Collaborator Author

ExE-Boss commented Feb 4, 2020

I’m willing to maintain this config file.

@tobie tobie merged commit f9269c9 into tobie:master Feb 4, 2020
@ExE-Boss ExE-Boss deleted the chore/vscode/add-schema-validation branch February 4, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants