Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Picture-in-Picture API compat data #9438

Merged
merged 16 commits into from
Mar 12, 2021
Merged

Update Picture-in-Picture API compat data #9438

merged 16 commits into from
Mar 12, 2021

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Mar 12, 2021

These changes were prepared by @gsouquet in another PR:
#7028

Closes #7028.

Co-authored-by: Germain germain@grabyo.com
Co-authored-by: Daniel D. Beck daniel@ddbeck.com

These changes were prepared by @gsouquet in another PR:
mdn#7028

Closes mdn#7028.

Co-authored-by: Germain <germain@grabyo.com>
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Mar 12, 2021
@foolip
Copy link
Collaborator Author

foolip commented Mar 12, 2021

The initial state of this PR is #7028 without modifications. I'll now make the changes needed.

@@ -49,15 +49,39 @@
},
"autoPictureInPicture": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLVideoElement/autoPictureInPicture",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@foolip foolip marked this pull request as ready for review March 12, 2021 15:18
@foolip
Copy link
Collaborator Author

foolip commented Mar 12, 2021

This is quite complicated, but ready for review now. Main things to know:

  • autoPictureInPicture is a separate feature, under a separate flag in Chromium. Only shipped in Safari so far.
  • PictureInPictureEvent was initially called EnterPictureInPictureEvent in both Chrome and Safari. The "leavepictureinpictureevent" existed, but fired a regular Event. That was then changed to fire PictureInPictureEvent, so that those events would also get the pictureInPictureWindow attribute.

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @foolip (and @gsouquet)! 🎉

@ddbeck ddbeck merged commit 1118f6b into mdn:master Mar 12, 2021
@foolip foolip deleted the pip branch March 12, 2021 18:15
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Mar 12, 2021
ddbeck added a commit that referenced this pull request Mar 18, 2021
* Start release notes for 2021-03-18 release

* Add release note for #9438

* Add release note for #9459

* Add release note for #9458

* Add release note for #9382

* Add release note for #9439

* Add release note for #9468

* Add release note for #9472

* Add release note for #9433

* Add release statistics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants