-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CSS] Add svh/svw, lvh/lvw, dvh/dvw length units #15465
Comments
This has also shipped in Safari 15.4 |
Status:
|
Hi @queengooborg, I need your help with this feature. The BCD table requires an update. Specifically,
I'd really appreciate your help in updating the table BCD for this feature. |
@dipikabh I'll help you get started with this.
I don't think this is correct. The compat table right now show that But this fix that you are documenting implements them in Firefox right? (thats' what I see here https://hg.mozilla.org/mozilla-central/rev/d9a19df80e22, and there is no obvious preference hiding it). So basically this will be implemented in two browser engines and is hence no longer experimental. The actions you need to take (if I am correct in my assumptions above) are:
Make sense?
It makes no difference for vi, vb because those are already recorded in the BCD as supported in this version. But as discussed above, those ones are no longer experimental once both FF and Safari support the features. Quick search on "Safari 15.4 Release notes" brings up https://developer.apple.com/documentation/safari-release-notes/safari-15_4-release-notes#New-Features "Added support for small (svw, svh, svi, svb, svmin, svmax), large (lvw, lvh, lvi, lvb, lvmin, lvmax), dynamic (dvw, dvh, dvi, dvb, dvmin, dvmax), and logical (vi, vb) viewport units. You'll need to check the mapping, but that looks like they have 1:1 parity with Firefox - so we need to add entries for these for both Safari and FF. For due diligence you'd do a basic web search on Chrome too. CanIuse thinks they are implemented behind a flag so worth doing some testing to verify https://caniuse.com/viewport-unit-variants
BCD is about identifying compatibility differences. If all the browser engines are likely to release the same sets of functionality together they could be grouped. In that case it could be a single feature like If you don't have a good feel for how the features will be delivered you can split them up a bit finer to start with. If it were me I'd split into subfeatures: Enough to get you started? |
Thanks, @hamishwillee! Yes, that is very very helpful. I can definitely give it a go. |
Acceptance Criteria
For folks helping with Firefox related documentation
dev-doc-complete
or
Features to document
Add svh/svw, lvh/lvw, dvh/dvw length units (and *i/*b logical versions)
Related Gecko bugs
https://bugzilla.mozilla.org/show_bug.cgi?id=1610815
The text was updated successfully, but these errors were encountered: