-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content bug: Wrong header-types for Transfer-Encoding and Trailer headers #4889
Comments
Thanks @singla-shivam . I think you're definitely right, and these are not "response headers". The definition of general headers here is "apply to both requests and responses, but with no relation to the data transmitted in the body.". Even if not quite right though, I think more clear to users than having "response header". @sideshowbarker What do you think? I'm wondering if we should really use "General header" (ever) since it isn't in the spec, and instead mark things as both Request or Response header if they are both. Specs
|
Yeah, I think we should avoid using any term that’s not used in the current HTTP spec.
Yes, that seems to me like the right thing to do.
I’m not aware of browsers ever sending a
That seems to imply the spec at least doesn’t rule out the possibility for transfer coding to specified in a request (and thus for a request to have a |
Excellent. Given this is a change in "what we do", who should we ask for approval from? Because we should do this at least a bit "globally". |
@Elchi3 Chris suggest you might be a good person to advise re #4889 (comment) above. Specifically, in the HTTP Header info tables we refer to them being as request, response, general and (possibly) representation/Entity headers. We use "General" to be mean "either request or response header based on context, unless is to do with payload representation". But the docs are specific in that they say General is not a spec term - so perhaps we should just have header type as both in a comma separated list? |
hm, yes, it's possible we took this definition from an older RFC (https://datatracker.ietf.org/doc/html/rfc2616#section-4.5) when we first wrote the MDN HTTP docs. I think your suggestion to just have header types in a comma separated list makes a lot of sense. It is more clear anyways, "general" is quite generic :) |
What page(s) did you find the problem on?
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Trailer
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Transfer-Encoding
Specific page section or heading?
Transfer-Encoding
andTrailer
headersWhat is the problem?
In the docs, the header type for
Transfer-Encoding
andTrailer
headers is marked asResponse header
.What did you expect to see?
They should have been marked as
General header
Did you test this? If so, how?
References and research:-
Transfer-Encoding
andTrailer
headers are response headers. Everywhere sender-receiver is mentioned. (Argument from-TE
header is explicitly said as request header).Transfer-Encoding
andTrailer
headers are mentioned separately in request and response headers.cat my_file | curl -T- http://127.0.0.1:8080
to see if the transfer-encoding is applied to the request or not. Result- yes it is applied.The text was updated successfully, but these errors were encountered: