Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify HTTP General headers to refer to Request/Response headers #4984

Merged
merged 2 commits into from
May 17, 2021

Conversation

hamishwillee
Copy link
Collaborator

The term "General header" is no longer used in the HTTP/1.1 spec. This change replaces that glossary term in the HTTP header doc information tables that are affected by a comma separate list of the Request, Response headers.

Discussion on this in #4889 (comment)

There is more work to be done around this, but will do as separate PR.

@hamishwillee hamishwillee requested a review from a team as a code owner May 14, 2021 05:22
@hamishwillee hamishwillee requested review from mirunacurtean and Elchi3 and removed request for a team May 14, 2021 05:22
@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2021

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/HTTP/Headers/Pragma
Title: Pragma
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Headers/Upgrade
Title: Upgrade
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Headers/Connection
Title: Connection
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Headers/Via
Title: Via
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Headers/Cache-Control
Title: Cache-Control
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Headers/Content-Disposition
Title: Content-Disposition
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Headers/Date
Title: Date
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Headers/Want-Digest
Title: Want-Digest
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Headers/Keep-Alive
Title: Keep-Alive
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Headers/Transfer-Encoding
Title: Transfer-Encoding
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Headers/Warning
Title: Warning
on GitHub


URL: /en-US/docs/Web/HTTP/Headers/Trailer
Title: Trailer
on GitHub

No new external URLs

(this comment was updated 2021-05-17 04:42:21.553819)

@hamishwillee
Copy link
Collaborator Author

FYI, further "associated" work on this done in #4988.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I wonder if you want to update the "General Header" tags in the front matter in this PR? Otherwise a follow up on that would be good.

@hamishwillee
Copy link
Collaborator Author

hamishwillee commented May 17, 2021

@Elchi3 Thanks for the review. Yes, I would like to fix up the tags (done). This was a bit of a mishmash. In all cases they now have at least this set:

  • HTTP
  • HTTP Header
  • Request header
  • Response header
  • Reference
    Ready for re-review

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@Elchi3 Elchi3 merged commit b78d681 into mdn:main May 17, 2021
@hamishwillee hamishwillee deleted the general_header branch May 18, 2021 00:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants