-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify HTTP General headers to refer to Request/Response headers #4984
Conversation
FYI, further "associated" work on this done in #4988. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I wonder if you want to update the "General Header" tags in the front matter in this PR? Otherwise a follow up on that would be good.
@Elchi3 Thanks for the review. Yes, I would like to fix up the tags (done). This was a bit of a mishmash. In all cases they now have at least this set:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👍
The term "General header" is no longer used in the HTTP/1.1 spec. This change replaces that glossary term in the HTTP header doc information tables that are affected by a comma separate list of the Request, Response headers.
Discussion on this in #4889 (comment)
There is more work to be done around this, but will do as separate PR.