-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fetchpriority to match final spec #24520
Conversation
Preview URLs (9 pages)
Flaws (12)Note! 6 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
External URLs (2)URL:
(comment last updated: 2023-02-18 15:28:43) |
Thanks for this update, @pmeenan !
Yes, on MDN we usually don't document dictionaries like this as standalone objects/pages. We just document them inline in the place they are used, so here it looks like we should update the |
@wbamberg Thanks. I updated the I also put the experimental flag back since neither WebKit nor Gecko's implementations have made it to a stable browser yet. I'll submit another PR once that happens to include the version info and remove the flag. |
This pull request has merge conflicts that must be resolved before it can be merged. |
1 similar comment
This pull request has merge conflicts that must be resolved before it can be merged. |
3970dc1
to
e2bced3
Compare
Sorry, rebase went horribly wrong - will submit a new, clean PR |
Clean PR created: #24595 |
Description
This updates the
fetchpriority
HTML attribute andpriority
fetch option to match the final spec.Motivation
The Priority Hints spec was merged into the HTML and fetch specs, obsoleting the original spec.
Additional details
Here is the HTML spec PR and the Fetch spec PR.
Summarized changes:
fetchPriority
attribute (was never implemented anywhere).priority
option as part of creating a fetch request was updated.importance
attribute was updated.One thing that I couldn't quite make out is that the Fetch spec accounts for a
Request
object but also aRequestInit
object that is used when constructing a request. Thepriority
is not readable fromRequest
, it is only settable at construct time. I removed it from the JSON and Request interfaces and added it to the main fetch page where it talks about constructor options but theRequestInit
itself doesn't appear to be directly documented.Related issues and pull requests
Fixes #24519