Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fetchPriority to match the final spec #24595

Merged
merged 2 commits into from
Feb 20, 2023
Merged

Conversation

pmeenan
Copy link
Contributor

@pmeenan pmeenan commented Feb 19, 2023

Description

This updates the fetchpriority HTML attribute and priority fetch option to match the final spec. This is a cleaner version of this PR that had rebase issues.

Motivation

The Priority Hints spec was merged into the HTML and fetch specs, obsoleting the original spec.

Additional details

Here is the HTML spec PR and the Fetch spec PR.

Summarized changes:

  • The iFrame element no longer supports the fetchPriority attribute (was never implemented anywhere).
  • Remove the priority attribute from the Request interface (it is only settable through options).
  • The priority option as part of creating a fetch request and constructing a request was updated.
  • A stray reference to the old importance attribute was updated.

Related issues and pull requests

Fixes #24519

@pmeenan pmeenan requested review from a team as code owners February 19, 2023 17:42
@pmeenan pmeenan requested review from sideshowbarker, estelle and bsmth and removed request for a team February 19, 2023 17:42
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs Content:Learn Learning area docs Content:WebAPI Web API docs labels Feb 19, 2023
@github-actions
Copy link
Contributor

Preview URLs (6 pages)
Flaws (2)

Note! 4 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Request/Request
Title: Request()
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/API/abortsignal

URL: /en-US/docs/Web/HTML/Element/iframe
Title: <iframe>: The Inline Frame element
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Learn/Common_questions/What_is_a_URL
External URLs (7)

URL: /en-US/docs/Web/HTML/Attributes
Title: HTML attribute reference


URL: /en-US/docs/Web/HTML/Element/iframe
Title: <iframe>: The Inline Frame element

@sideshowbarker sideshowbarker merged commit 076a9f9 into mdn:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTML Hypertext Markup Language docs Content:Learn Learning area docs Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move fetchpriority references to HTML and fetch specs
2 participants