Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module landing page: scrollbar styles #26400

Merged
merged 14 commits into from
Apr 26, 2023
Merged

Module landing page: scrollbar styles #26400

merged 14 commits into from
Apr 26, 2023

Conversation

estelle
Copy link
Member

@estelle estelle commented Apr 25, 2023 •
edited
Loading

@estelle estelle requested a review from a team as a code owner April 25, 2023 02:03
@estelle estelle requested review from dipikabh and removed request for a team April 25, 2023 02:03
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Apr 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2023 •
edited
Loading

Preview URLs

Flaws (1)

URL: /en-US/docs/Web/CSS/CSS_Scrollbars
Title: CSS scrollbars styling
Flaw count: 1

  • macros:
    • /en-US/docs/Glossary/scrollport redirects to /en-US/docs/Glossary/Scroll_container

(comment last updated: 2023-04-26 20:48:46)

@dipikabh dipikabh self-assigned this Apr 25, 2023
@dipikabh
Copy link
Contributor

I'll take a look at this tomorrow 👍

@estelle estelle mentioned this pull request Apr 25, 2023
Closed
teoli2003
teoli2003 previously requested changes Apr 25, 2023
View reviewed changes
files/en-us/web/css/css_scrollbars/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_scrollbars/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_scrollbars/index.md Outdated Show resolved Hide resolved
dipikabh
dipikabh requested changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added my comments

files/en-us/web/css/css_scrollbars/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_scrollbars/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_scrollbars/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_scrollbars/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_scrollbars/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_scrollbars/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_scrollbars/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_scrollbars/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_scrollbars/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_scrollbars/index.md Outdated Show resolved Hide resolved
estelle and others added 2 commits April 25, 2023 12:01
@estelle @dipikabh
Update files/en-us/web/css/css_scrollbars/index.md
33f6194 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@estelle @dipikabh @teoli2003
Apply suggestions from code review
1149949 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
@estelle estelle mentioned this pull request Apr 25, 2023
Merged
@estelle @dipikabh
Update files/en-us/web/css/css_scrollbars/index.md
7c09625 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
dipikabh
dipikabh requested changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. Added two follow-up changes

files/en-us/web/css/css_scrollbars/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/css_scrollbars/index.md Show resolved Hide resolved
@estelle estelle mentioned this pull request Apr 26, 2023
Merged
estelle and others added 2 commits April 26, 2023 11:34
@estelle @dipikabh
Update files/en-us/web/css/css_scrollbars/index.md
a754b44 
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
@estelle
remove compat
fefbdc6
@estelle estelle requested a review from dipikabh April 26, 2023 18:35
dipikabh
dipikabh previously requested changes Apr 26, 2023
View reviewed changes
files/en-us/web/css/css_scrollbars/index.md Outdated Show resolved Hide resolved
@dipikabh dipikabh dismissed their stale review April 26, 2023 20:46

requested changes done

@dipikabh dipikabh dismissed teoli2003’s stale review April 26, 2023 20:49

requested changes are complete

@dipikabh dipikabh merged commit 04833ec into mdn:main Apr 26, 2023
@estelle estelle deleted the scrollstyle branch August 3, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipikabh dipikabh dipikabh approved these changes

@teoli2003 teoli2003 Awaiting requested review from teoli2003

Assignees

@dipikabh dipikabh

Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

web/css/css_scrollbars/ -
3 participants
@estelle @dipikabh @teoli2003