-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(manifest): Improve display
member page
#34386
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview URLs (comment last updated: 2024-07-09 12:22:51) |
pepelsbey
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you :)
Co-authored-by: Vadim Makeev <hi@pepelsbey.dev>
Thanks a lot for the review, @pepelsbey. |
evelinabe
pushed a commit
to evelinabe/mdn-content
that referenced
this pull request
Jul 12, 2024
* improves manifest display page * adjust desc and value * fix typo * Update files/en-us/web/manifest/display/index.md Co-authored-by: Vadim Makeev <hi@pepelsbey.dev> --------- Co-authored-by: Vadim Makeev <hi@pepelsbey.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This work is part of improving the web/manifest docs. This PR focuses on the
display
member page.A few notable changes done in this PR:
Formatting/layout changes:
Content improvements:
fullscreen
vsFullscreen API
display-mode
media feature vsdisplay
manifest memberdisplay
member in context with other members of the manifest file.Motivation
To add more usage examples, update information from spec, make the page compliant with our page templates
Additional details
Related issues and pull requests
mdn/mdn#560