-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(manifest): Improve icons
member page
#34725
Conversation
Preview URLs
External URLs (1)URL:
(comment last updated: 2024-09-16 22:08:34) |
icons
member pageicons
member page
71da5ab
to
aa7eaee
Compare
Hi @hamishwillee, thanks a lot for the review and valuable inputs. Sorry, I was able to get back to this PR only now so you might need to refresh your memory again on this. I've addressed all your comments and indicated parts that are slightly different from the suggestions. For |
Just a nudge to bring this back on your reviewing radar when you get the chance :). Thanks! |
fd15cc8
to
383ab26
Compare
Hi @hamishwillee, I've applied the formatting to two other members:
If it makes it simpler, I can gt rid of the Syntax section (and upgrade Keys to H2). |
Co-authored-by: Dipika Bhattacharya <dipika@foss-community.org>
New structure looks good to me. I added a few comments/suggestions. The most important is https://github.com/mdn/content/pull/34725/files#r1759389846 |
Thanks, Hamish, for your time and patience in ironing out the Syntax block format and brainstorming all the Values/Keys/Properties shenanigans. Appreciate you taking another close look at the rest of the content. The latest set of updates are in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dipikabh Thanks for this - looks good to me - worth getting this in, fixing up all the rest to match, then we can iterate.
It is a lot easier to be critical than to generate new content and structures in the first place :-)
Description
This work is part of improving the web/manifest docs. This PR focuses on the
icons
member page.Some notable changes in this PR:
Motivation
To better explain the properties and example and make the page compliant with our page templates
Additional details
Spec links:
Related issues and pull requests
Tracking issue: mdn/mdn#560
display
page PR: #34386