Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add representation header and replace Entity header where appropriate #4988

Merged
merged 6 commits into from
May 14, 2021

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented May 14, 2021

Latest HTTP spec doesn't talk about Entity headers, but "representation headers". This adds representation header docs and cross links to them from headers where appropriate. Also deprecates the entity header doc.

What was wrong/why is this fix needed? (quick summary only)

Entity headers are confusing, as we refer to them but specs do not.

I still need to update a couple of docs around General headers:

@hamishwillee hamishwillee requested review from a team as code owners May 14, 2021 07:37
@hamishwillee hamishwillee requested review from chrisdavidmills and removed request for a team May 14, 2021 07:37
@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2021

Preview URLs

Flaws

Note! 7 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/HTTP/Headers
Title: HTTP headers
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Glossary/COEP does not exist
    • /en-US/docs/Glossary/COOP does not exist
    • /en-US/docs/Glossary/CORP does not exist

External URLs

URL: /en-US/docs/Glossary/HTTP_header
Title: HTTP header
on GitHub

No new external URLs


URL: /en-US/docs/Glossary/Representation_header
Title: Representation header
on GitHub


URL: /en-US/docs/Glossary/Entity_header
Title: Entity header
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Headers
Title: HTTP headers
on GitHub


URL: /en-US/docs/Web/HTTP/Headers/Content-Language
Title: Content-Language
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Headers/Content-Type
Title: Content-Type
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Headers/Content-Encoding
Title: Content-Encoding
on GitHub


URL: /en-US/docs/Web/HTTP/Headers/Content-Location
Title: Content-Location
on GitHub

No new external URLs

(this comment was updated 2021-05-14 07:47:32.017191)

- HTTP
- Headers
- Reference
browser-compat: http.headers.Content-Encoding
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Elchi3 Note, this allowed me to pull compat in using macro below. BUT I got an error pulling in specifications even though this IS defined in the compatibility info.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hamishwillee! This will work after w3c/browser-specs#280 is fixed.

Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; let's get this merged!

@chrisdavidmills chrisdavidmills merged commit c79fbf8 into mdn:main May 14, 2021
@hamishwillee hamishwillee deleted the http_header_tidy branch May 17, 2021 04:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants