PR hygiene checking

[peterbe]

fixes #782

Here's what it looks like if the PR title was Update index.html

And if all is well:

Not rocket science but hopefully a start.

[nschonni]

https://github.com/marketplace/actions/conventional-pr-title-alt might be another interesting option

Edit: or one of these https://github.com/marketplace?type=actions&query=title

[peterbe]

https://github.com/marketplace/actions/conventional-pr-title-alt might be another interesting option

Edit: or one of these https://github.com/marketplace?type=actions&query=title

I looked at most of those and didn't feel attracted to any of them. They all seemed overly complicated or just not perfect. And besides, I quite like the idea of building it "from scratch" because then you're limitless in what you want to implement. Our current logic is a bit odd in that it's so oddly specific. And we can now quite easily express our business logic with simple string-checking if-statements in JavaScript rather than custom regexes in a Yaml file.

[escattone]

This seems like a good start to me, thanks @peterbe!

[peterbe]

ping @fiji-flo

[peterbe]

One thing I've found for myself is that when I do a lot of flaw fixing PRs, I never type in a description. Because it's rarely useful when the summary is sufficient.

[Ryuno-Ki]

This looks ready to merge (from a CI point of view)

[peterbe]

I changed my mind. I made it less controversial so that it doesn't require that the description is non-empty.
I've made many PRs on the content and I often find that once you've typed a decent title, there's really nothing else worth saying in the description. At least not worthy enough for it to block in CI.

[peterbe]

@fiji-flo Do you mind if I merge without your review?