Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.html title not very helpful #782

Closed
hamishwillee opened this issue Dec 30, 2020 · 4 comments · Fixed by #910
Closed

Update index.html title not very helpful #782

hamishwillee opened this issue Dec 30, 2020 · 4 comments · Fixed by #910
Assignees

Comments

@hamishwillee
Copy link
Collaborator

Github bases issue names based on the title. Because all our files are named index.html we end up with lots of issues named Update index.html.

Can we trick github to grab the name from the parent folder by default?

@chrisdavidmills
Copy link
Contributor

This is an interesting point. @escattone @peterbe is there a way we can do this?

@nschonni
Copy link
Contributor

nschonni commented Jan 1, 2021

Maybe as a stop-gap (as I don't think you can fix the GitHub behaviour), would be to add a small CI job to fail if the title is "Update index.html" and add a comment to please give a more descriptive name.

It might be possible to do that same job to update the title though ...

@peterbe
Copy link
Contributor

peterbe commented Jan 4, 2021

I'm doubtful that we can coax how the GitHub UI works. But it's clearly a common thing.
I think it would make sense to do something like @nschonni suggested.

peterbe added a commit to peterbe/content that referenced this issue Jan 4, 2021
@peterbe
Copy link
Contributor

peterbe commented Jan 4, 2021

I have a PR coming that is at least the beginning of a solution to this.

(I admit, I spent too much time on it but I think there's always value in learning more about what you can do with GitHub Actions).

@peterbe peterbe self-assigned this Jan 4, 2021
escattone pushed a commit that referenced this issue Feb 3, 2021
* pr lint check

Fixes #782

* undo

* ignore more

* remove env.GIT_DIFF

* only context

* run it

* remove env.GIT_DIFF

* unbreak cache

* updates

* updates

* all types

* set -e

* don't catch

* set -e needed?

* debugging

* better errors

* testing

* testing

* using returns

* using returns

* last cleanup

* remove debug

* touchups

* touchups

* remove emojis

* remove the need for the PR description to be filled in
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants