Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fr: Make sure localized links are used rather than /en-US/* #14249

Merged
merged 3 commits into from
Jul 16, 2023

Conversation

queengooborg
Copy link
Collaborator

This PR fixes all of the links within the French locale so that they no longer point to English content.

@queengooborg queengooborg requested a review from a team as a code owner July 15, 2023 07:44
@queengooborg queengooborg requested review from cw118 and removed request for a team July 15, 2023 07:44
@github-actions github-actions bot added the l10n-fr Issues related to French content. label Jul 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2023

Preview URLs (35 pages)
Flaws (280)

Note! 3 documents with no flaws that don't need to be listed. 🎉

URL: /fr/docs/Learn/HTML/Multimedia_and_embedding/Other_embedding_technologies
Title: Des objets aux iframes — autres techniques d'intégration
Flaw count: 85

  • macros:
    • /fr/docs/Learn/CSS/Building_blocks/Cascade_layers does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Cascade_layers
    • /fr/docs/Learn/CSS/Building_blocks/Images_media_form_elements does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Images_media_form_elements
    • /fr/docs/Learn/CSS/Building_blocks/Organizing does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Organizing
    • /fr/docs/Learn/JavaScript/Asynchronous/Implementing_a_promise-based_API does not exist but fell back to /en-US/docs/Learn/JavaScript/Asynchronous/Implementing_a_promise-based_API
    • /fr/docs/Learn/JavaScript/Asynchronous/Sequencing_animations does not exist but fell back to /en-US/docs/Learn/JavaScript/Asynchronous/Sequencing_animations
    • and 67 more flaws omitted
  • broken_links:
    • Is currently http:// but can become https://
    • Can't resolve /fr/docs/Learn/Common_questions/What_are_browser_developer_tools
    • Can't resolve /fr/docs/Learn/Common_questions/Using_Github_pages
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • and 7 more flaws omitted
  • translation_differences:
    • Differences in the important macros (1 in common of 3 possible)

URL: /fr/docs/Web/Accessibility/ARIA/Roles/button_role
Title: ARIA : le rôle button
Flaw count: 10

  • macros:
    • `/home/runner/work/translated-content/translated-content/mdn/content/node_modules/@mdn/yari/kumascript/macros/ListSubpagesForSidebar.ejs:1

1| <%
2| // Inserts a tree of subpages of the specified page to be used in the sidebar (quicklinks)
3| // Displays common flags/icons
4| // Includes the parent page at the top of the list.

pages is not iterable`

  • broken_links:
    • Can't resolve /fr/docs/Web/HTML/Element/Button
    • Can't resolve /fr/docs/Web/HTML/Element/Input
    • Can use the English (en-US) link as a fallback
    • Can't resolve /fr/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-label_attribute
    • Can't resolve /fr/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-labelledby_attribute
    • and 3 more flaws omitted
  • translation_differences:
    • Differences in the important macros (1 in common of 5 possible)

URL: /fr/docs/Web/HTTP/Basics_of_HTTP/Identifying_resources_on_the_Web
Title: Identifier des ressources sur le Web
Flaw count: 4

  • macros:
    • `/home/runner/work/translated-content/translated-content/mdn/content/node_modules/@mdn/yari/kumascript/macros/Compat.ejs:1

1| <%
2| /*
3|
4| Retrieves MDN compat data for a given feature

No first query argument or 'browser-compat' front-matter value passed`

  • broken_links:
    • Can't resolve /fr/docs/Web/HTTP/Basics_of_HTTP/Data_URIs
    • Can't resolve /fr/docs/Learn/Common_questions/What_is_a_URL
  • translation_differences:
    • Differences in the important macros (2 in common of 3 possible)

URL: /fr/docs/Web/Progressive_web_apps/Tutorials/js13kGames
Title: Introduction aux progressive web apps
Flaw count: 11

  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • and 6 more flaws omitted

URL: /fr/docs/Web/Progressive_web_apps/Tutorials/js13kGames/App_structure
Title: Structure d'une Progressive web app
Flaw count: 5

  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can't resolve /fr/docs/Mozilla/Mobile/Viewport_meta_tag
    • Can't resolve /fr/docs/Web/CSS/Media_Queries/Using_media_queries
    • Can't resolve /fr/docs/Web/CSS/CSS_Flexible_Box_Layout
    • Can't resolve /fr/docs/Web/CSS/CSS_Grid_Layout

URL: /fr/docs/Web/Progressive_web_apps/Tutorials/js13kGames/Loading
Title: Chargement progressif
Flaw count: 6

  • broken_links:
    • Can't resolve /fr/docs/Web/Progressive_web_apps/Re-engageable_Notifications_Push
    • Can't resolve /fr/docs/Web/Progressive_web_apps/Installable_PWAs
    • Can't resolve /fr/docs/Web/Progressive_web_apps/Introduction
    • Can't resolve /fr/docs/Web/Progressive_web_apps/App_structure
    • Can't resolve /fr/docs/Web/Progressive_web_apps/Offline_Service_workers
    • and 1 more flaws omitted

URL: /fr/docs/Web/Progressive_web_apps/Tutorials/js13kGames/Re-engageable_Notifications_Push
Title: Comment faire pour que les PWAs relancent les utilisateurs en utilisant des notifications et des messages poussés
Flaw count: 6

  • macros:
    • /fr/docs/Web/API/PushManager does not exist but fell back to /en-US/docs/Web/API/PushManager
    • /fr/docs/Web/API/PushManager/subscribe does not exist but fell back to /en-US/docs/Web/API/PushManager/subscribe
    • /fr/docs/Web/API/Onclick does not exist
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback

URL: /fr/docs/Web/Progressive_web_apps/Tutorials/js13kGames/Offline_Service_workers
Title: Faire fonctionner les PWAs en mode déconnecté grâce aux Service workers
Flaw count: 4

  • macros:
    • /fr/docs/Web/API/ExtendableEvent/waitUntil does not exist but fell back to /en-US/docs/Web/API/ExtendableEvent/waitUntil
    • /fr/docs/Web/API/FetchEvent/respondWith does not exist but fell back to /en-US/docs/Web/API/FetchEvent/respondWith
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can't resolve /fr/docs/Web/API/IndexedDB_API/Browser_storage_limits_and_eviction_criteria

URL: /fr/docs/Web/Progressive_web_apps/Tutorials/js13kGames/Installable_PWAs
Title: Comment rendre les PWA installables
Flaw count: 2

  • broken_links:
    • Can't resolve /fr/Apps/Progressive/Add_to_home_screen#Manifest
    • Can use the English (en-US) link as a fallback

URL: /fr/docs/Web/API/ExtendableMessageEvent/lastEventId
Title: ExtendableMessageEvent.lastEventId
Flaw count: 6

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • /fr/docs/Web/API/PushMessageData does not exist but fell back to /en-US/docs/Web/API/PushMessageData
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (3 in common of 4 possible)

URL: /fr/docs/Web/API/MediaDevices
Title: MediaDevices
Flaw count: 10

  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • and 5 more flaws omitted

URL: /fr/docs/Web/API/IDBObjectStore/createIndex
Title: IDBObjectStore.createIndex()
Flaw count: 1

  • macros:
    • /fr/docs/Web/API/IDBOpenDBRequest/onupgradeneeded does not exist but fell back to /en-US/docs/Web/API/IDBOpenDBRequest/upgradeneeded_event

URL: /fr/docs/Web/API/HTMLCanvasElement
Title: HTMLCanvasElement
Flaw count: 13

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • /fr/docs/Web/API/RenderingContext does not exist
    • /fr/docs/Web/API/Boolean does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Boolean
    • /fr/docs/Web/API/Boolean does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Boolean
    • /fr/docs/Web/API/CanvasProxy does not exist
    • and 7 more flaws omitted
  • translation_differences:
    • Differences in the important macros (2 in common of 4 possible)

URL: /fr/docs/Web/API/Document/domain
Title: Document.domain
Flaw count: 5

  • broken_links:
    • Can't resolve /fr/docs/Web/JavaScript/Same_origin_policy_for_JavaScript
    • Can't resolve /fr/docs/XPCOM_Interface_Reference/nsIEffectiveTLDService#getBaseDomain.28.29
    • Is currently http:// but can become https://
    • Can't resolve /fr/docs/Web/JavaScript/Same_origin_policy_for_JavaScript
  • translation_differences:
    • Differences in the important macros (1 in common of 3 possible)

URL: /fr/docs/Web/API/URL/toString
Title: URL.toString()
Flaw count: 3

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • /fr/docs/Web/API/URL/href does not exist but fell back to /en-US/docs/Web/API/URL/href
    • wrong xref macro used (consider changing which macro you use)

URL: /fr/docs/Web/API/URL/hash
Title: URL.hash
Flaw count: 3

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
  • broken_links:
    • Can't resolve /fr/docs/Glossary/percent-encoding

URL: /fr/docs/Web/API/URL/protocol
Title: URL.protocol
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)

URL: /fr/docs/Web/API/URL/search
Title: URL.search
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)

URL: /fr/docs/Web/API/URL/toJSON
Title: URL.toJSON()
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)

URL: /fr/docs/Web/API/Element/transitionend_event
Title: Document: évènement transitionend
Flaw count: 11

  • macros:
    • /fr/docs/Web/API/GlobalEventHandlers/ontransitionend does not exist but fell back to /en-US/docs/Web/API/Element/transitionend_event
  • broken_links:
    • Can't resolve /fr/docs/Web/CSS/CSS_Transitions/Utiliser_transitions_CSS
    • Can use the English (en-US) link as a fallback
    • Can't resolve /fr/docs/Web/Events/transitionend
    • Can't resolve /fr/docs/Web/API/HTMLElement/transitionend_event#Live_example
    • Can use the English (en-US) link as a fallback
    • and 4 more flaws omitted
  • translation_differences:
    • Differences in the important macros (3 in common of 4 possible)

URL: /fr/docs/Web/API/SubtleCrypto
Title: SubtleCrypto
Flaw count: 26

  • macros:
    • /fr/docs/Web/API/Window/crypto redirects to /fr/docs/Web/API/crypto_property
    • /fr/docs/Web/API/SubtleCrypto/encrypt does not exist but fell back to /en-US/docs/Web/API/SubtleCrypto/encrypt
    • /fr/docs/Web/API/SubtleCrypto/decrypt does not exist but fell back to /en-US/docs/Web/API/SubtleCrypto/decrypt
    • /fr/docs/Web/API/SubtleCrypto/sign does not exist but fell back to /en-US/docs/Web/API/SubtleCrypto/sign
    • /fr/docs/Web/API/SubtleCrypto/verify does not exist but fell back to /en-US/docs/Web/API/SubtleCrypto/verify
    • and 20 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback

URL: /fr/docs/Web/API/Location/replace
Title: Location.replace()
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
  • translation_differences:
    • Differences in the important macros (2 in common of 4 possible)

URL: /fr/docs/Web/API/Location/assign
Title: Location.assign()
Flaw count: 2

  • macros:
    • wrong xref macro used (consider changing which macro you use)
  • translation_differences:
    • Differences in the important macros (2 in common of 4 possible)

URL: /fr/docs/Web/API/Window/vrdisplayconnect_event
Title: Window: vrdisplayconnect event
Flaw count: 3

  • macros:
    • /fr/docs/Web/API/VRDisplayEvent does not exist but fell back to /en-US/docs/Web/API/VRDisplayEvent
  • broken_links:
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (2 in common of 3 possible)

URL: /fr/docs/Web/API/Window/message_event
Title: Window: message event
Flaw count: 1

  • broken_links:
    • Can use the English (en-US) link as a fallback

URL: /fr/docs/Web/API/Window/vrdisplaypresentchange_event
Title: Window: vrdisplaypresentchange event
Flaw count: 3

  • macros:
    • /fr/docs/Web/API/VRDisplayEvent does not exist but fell back to /en-US/docs/Web/API/VRDisplayEvent
  • broken_links:
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (2 in common of 3 possible)

URL: /fr/docs/Web/API/Window/vrdisplaydisconnect_event
Title: Window: vrdisplaydisconnect event
Flaw count: 3

  • macros:
    • /fr/docs/Web/API/VRDisplayEvent does not exist but fell back to /en-US/docs/Web/API/VRDisplayEvent
  • broken_links:
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (2 in common of 3 possible)

URL: /fr/docs/Web/JavaScript/Reference/Operators/Destructuring_assignment
Title: Affecter par décomposition
Flaw count: 8

  • broken_links:
    • Can't resolve /fr/docs/Web/JavaScript/Guide/Valeurs,_variables,_et_littéraux#Litt.C3.A9raux_objets
    • Can't resolve /fr/docs/Web/JavaScript/Guide/Valeurs,_variables,_et_littéraux#Litt.C3.A9raux_de_tableaux
    • Can't resolve /fr/docs/JavaScript/Reference/Objets_globaux/Object/RegExp/Exec
    • Can't resolve /fr/docs/JavaScript/Référence_JavaScript/Instructions/for...of
    • Can't resolve /fr/docs/Web/JavaScript/Reference/Fonctions/paramètres_du_reste
    • and 1 more flaws omitted
  • heading_links:
    • h3 heading contains an <a> tag
  • translation_differences:
    • Differences in the important macros (3 in common of 5 possible)

URL: /fr/docs/Web/SVG/Tutorial/Other_content_in_SVG
Title: Contenu embarqué dans le SVG
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (0 in common of 3 possible)

URL: /fr/docs/Web/HTML/Microdata
Title: Microdonnées
Flaw count: 29

  • broken_links:
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • and 23 more flaws omitted
  • translation_differences:
    • Differences in the important macros (1 in common of 2 possible)

URL: /fr/docs/Web/HTML/microformats
Title: Microformats
Flaw count: 5

  • broken_links:
    • Can't resolve /fr/docs/Web/HTML/Element/Img#attr-alt
    • Can't resolve /fr/docs/Web/HTML/Element/Img
    • Can't resolve /fr/docs/Web/HTML/Element/Img
    • Can't resolve /fr/docs/Web/HTML/Element/Img#attr-src
  • translation_differences:
    • Differences in the important macros (0 in common of 1 possible)

URL: /fr/docs/Web/HTML/Element/main
Title: <main>
Flaw count: 6

  • macros:
    • /fr/docs/Web/HTML/Element/h2 redirects to /fr/docs/Web/HTML/Element/Heading_Elements
  • broken_links:
    • Can't resolve /fr/docs/Web/HTML/Attributs_universels
    • Can use the English (en-US) link as a fallback
    • No need for the pathname in anchor links if it's the same page
    • Anchor not lowercase
  • translation_differences:
    • Differences in the important macros (4 in common of 6 possible)

(comment last updated: 2023-07-16 20:57:06)

@queengooborg queengooborg deleted the fr/localized-links branch July 16, 2023 08:36
@queengooborg queengooborg restored the fr/localized-links branch July 16, 2023 08:37
@queengooborg queengooborg reopened this Jul 16, 2023
Copy link
Member

@cw118 cw118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo, nothing blocking though since it was not introduced by this PR

Co-authored-by: Carolyn Wu <87150472+cw118@users.noreply.github.com>
Copy link
Member

@cw118 cw118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much 🙏

@cw118 cw118 merged commit e7cb700 into main Jul 16, 2023
@cw118 cw118 deleted the fr/localized-links branch July 16, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-fr Issues related to French content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants