Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that internal links point to same locale #7413

Closed
16 tasks done
queengooborg opened this issue Aug 7, 2022 · 10 comments · Fixed by #14253
Closed
16 tasks done

Ensure that internal links point to same locale #7413

queengooborg opened this issue Aug 7, 2022 · 10 comments · Fixed by #14253
Labels
effort: small Task is a small effort. help wanted If you know something about this, we would love your help! l10n-ja Issues related to Japanese content.

Comments

@queengooborg
Copy link
Collaborator

queengooborg commented Aug 7, 2022

@cw118 cw118 added l10n-ja Issues related to Japanese content. l10n-fr Issues related to French content. l10n-zh Issues related to Chinese content. l10n-es Issues related to Spanish content. l10n-ru Issues related to Russian content. l10n-ko Issues related to Korean content. l10n-pt-br Issues related to Brazilian Portuguese labels Aug 7, 2022
@awxiaoxian2020
Copy link
Contributor

consider mdn/mdn-community#144 ?

@cw118 cw118 closed this as completed in 61c0099 Aug 9, 2022
@cw118
Copy link
Member

cw118 commented Aug 9, 2022

Done for fr in #7418

@cw118 cw118 reopened this Aug 9, 2022
@cw118 cw118 removed the l10n-fr Issues related to French content. label Aug 9, 2022
@queengooborg queengooborg added the help wanted If you know something about this, we would love your help! label Aug 9, 2022
@SnowMarble
Copy link
Contributor

Done for ko in #7461

@yin1999 yin1999 removed the l10n-ko Issues related to Korean content. label Aug 10, 2022
@yin1999 yin1999 removed the l10n-zh Issues related to Chinese content. label Sep 14, 2022
@yin1999
Copy link
Member

yin1999 commented Sep 14, 2022

Done for l10n-zh

@mfuji09
Copy link
Collaborator

mfuji09 commented Oct 2, 2022

Done for ja by #8808

@Graywolf9
Copy link
Contributor

Done for es in #10123 and #10126

@queengooborg
Copy link
Collaborator Author

During formatting runs (namely #14226), some more instances were found in completed locales. As such, I'm going to mark them as incomplete again, so that we can double-check and make sure no more instances remain. (I'll probably do that some time today!)

@queengooborg queengooborg added l10n-ja Issues related to Japanese content. l10n-fr Issues related to French content. l10n-zh Issues related to Chinese content. l10n-es Issues related to Spanish content. l10n-ko Issues related to Korean content. effort: small Task is a small effort. labels Jul 15, 2023
@yin1999
Copy link
Member

yin1999 commented Jul 15, 2023

Hi @queengooborg. Is it possible to add a rule to markdown-lint to prevent adding more links that are point to en-US?

@queengooborg
Copy link
Collaborator Author

I don't know if Markdownlint is powerful enough for that form of search and replace, but I will definitely be looking into it, and if so, tweaking the rule accordingly! (I'll also be looking into other solutions as well if we can't use Markdownlint!)

@yin1999
Copy link
Member

yin1999 commented Jul 16, 2023

I don't know if Markdownlint is powerful enough for that form of search and replace, but I will definitely be looking into it, and if so, tweaking the rule accordingly! (I'll also be looking into other solutions as well if we can't use Markdownlint!)

Maybe we could use mdast-util-from-markdown to iter over the links in document :) We have used this in mdn/yari

@yin1999 yin1999 removed the l10n-zh Issues related to Chinese content. label Jul 16, 2023
@yin1999 yin1999 removed l10n-fr Issues related to French content. l10n-es Issues related to Spanish content. l10n-ru Issues related to Russian content. l10n-ko Issues related to Korean content. l10n-pt-br Issues related to Brazilian Portuguese labels Jul 31, 2023
@yin1999 yin1999 linked a pull request Jul 31, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: small Task is a small effort. help wanted If you know something about this, we would love your help! l10n-ja Issues related to Japanese content.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants