-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ja: Make sure localized links are used rather than /en-US/* #14253
Conversation
Preview URLs (75 pages)
Flaws (395)Note! 43 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
External URLs (2)URL:
URL:
(comment last updated: 2023-08-06 04:37:54) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have replaced /en-US/ with /ja/ mechanically. But your modifications include example URLs or example messages from outer examples (e.g. in the GitHub), which make inconsistencies in their contexts.
I pointed out some of them. Please review the context of each change by yourself to see if it should be modified.
files/ja/learn/html/introduction_to_html/advanced_text_formatting/index.md
Show resolved
Hide resolved
files/ja/learn/html/introduction_to_html/advanced_text_formatting/index.md
Show resolved
Hide resolved
files/ja/learn/html/multimedia_and_embedding/other_embedding_technologies/index.md
Outdated
Show resolved
Hide resolved
Hi @mfuji09, thanks for taking a look! While this change is mostly mechanical, I did check through each change to make sure it seemed appropriate (for example, no (Note: I do not speak Japanese, so I will not be able to infer context as well.) In regards to the citations, I actually think that it is better to link to the localized versions. I say this because users will probably be inclined to click on the link to navigate to the page, even if it's just for a small peek. The more we can keep them on their desired locale, the better! |
This pull request has merge conflicts that must be resolved before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are more reviews.
There are too many changed files to review them at once.
So I'll review them step-by-step.
files/ja/learn/tools_and_testing/understanding_client-side_tools/command_line/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed the rest part of these changes.
files/ja/learn/html/multimedia_and_embedding/other_embedding_technologies/index.md
Outdated
Show resolved
Hide resolved
@@ -161,7 +161,7 @@ Example h-entry as a blog post: | |||
<p><span class="p-author h-card"> | |||
<a href="https://quickthoughts.jgregorymcverry.com/profile/jgmac1106" ><img class="u-photo" src="https://quickthoughts.jgregorymcverry.com/file/2d6c9cfed7ac8e849f492b5bc7e6a630/thumb.jpg"/></a> | |||
<a class="p-name u-url" href="https://quickthoughts.jgregorymcverry.com/profile/jgmac1106">Greg McVerry</a></span> | |||
Replied to <a class="u-in-reply-to" href="https://developer.mozilla.org/en-US/docs/Web/HTML/microformats">a post on | |||
Replied to <a class="u-in-reply-to" href="https://developer.mozilla.org/ja/docs/Web/HTML/microformats">a post on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The base language of this document is English. Do you think it should be a link to ja
even?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other locales have also changed this to point to their own locale, so I think this change is good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason something else "other locale also..."?
I think it is unnatural to link a localized document from English document (without any link for English version).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that it matters too much as this is just example code anyways, but I'll let you decide!
files/ja/web/javascript/reference/operators/destructuring_assignment/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Masahiro FUJIMOTO <mfujimot@gmail.com>
This pull request has merge conflicts that must be resolved before it can be merged. |
697059f
to
b24e709
Compare
This pull request has merge conflicts that must be resolved before it can be merged. |
This pull request has merge conflicts that must be resolved before it can be merged. |
This pull request has merge conflicts that must be resolved before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, but some of them may be reverted in future editing.
This PR fixes all of the links within the Japanese locale so that they no longer point to English content.